Oneric f5898ab0fb Fix malformed is_active qualifiers in User.Query usages ... While "is_active" is a property of users, it is not a recognised keyword for the User.Query helper; instead "deactivated" with negated value must be used. This arose because originally the user property was also called "deactivated" until it was renamed adn negated five years ago in 860b5c7804. This included renaiming the parameter in most but not all User.Query usages. Notably the parameter in User.get_followers_query was renamed but not in User.get_friends_query (friends == following). The accepted query parameter in User.Query however was not changed. This lead to the former mistakenly including deleted users causing too large values to be reported in the ActivityPub follower, but not following collection as reported in #1078. In Masto API responses filtering by `User.is_visible` weeded out the extra accounts before they got displayed to API users. On the surface it might seem logical to align the name of the User.Query parameter with the actual property name. However, User.Query already accepts an "active" parameter which is an alias for limiting to accounts which are neither deleted nor deactivated by moderators (both indicated by is_active) and also are not newly created account requests still pending an admin approval (is_approved) or necessary email confirmation (is_confirmed); in short as the alias suggests whether the account is active. Two highly similar parameter names like this would be much too confusing. The renamed "is_active" on the other hand does not actually suffice to say whether an account is actually active, only whether it has (not yet) ceased to be active (by its own volition or moderator action). Meaning its "new" name is actively misleading. Arguably the rename made things worse for no reason whatsoever and should not ever have happened. For now, we’ll just revert the incorrect query helper parameter renames. Fixes: https://akkoma.dev/AkkomaGang/akkoma/ issues/ 1078 (cherry picked from commit a899663ddc0e3a2084a239eabd79608a94ac5493)		2026-10-27 17:24:58 +04:00
..
tasks/pleroma	Fix malformed is_active qualifiers in User.Query usages	2026-10-27 17:24:58 +04:00
pleroma.ex	Fix warning	2026-04-01 19:10:29 +00:00