1156 lines
40 KiB
Elixir
1156 lines
40 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.ActivityPub.TransmogrifierTest do
|
|
use Oban.Testing, repo: Pleroma.Repo
|
|
use Pleroma.DataCase
|
|
|
|
alias Pleroma.Activity
|
|
alias Pleroma.Object
|
|
alias Pleroma.User
|
|
alias Pleroma.Web.ActivityPub.Builder
|
|
alias Pleroma.Web.ActivityPub.Pipeline
|
|
alias Pleroma.Web.ActivityPub.Transmogrifier
|
|
alias Pleroma.Web.ActivityPub.UserView
|
|
alias Pleroma.Web.ActivityPub.Utils
|
|
alias Pleroma.Web.AdminAPI.AccountView
|
|
alias Pleroma.Web.CommonAPI
|
|
|
|
import Mock
|
|
import Pleroma.Factory
|
|
import ExUnit.CaptureLog
|
|
|
|
setup_all do
|
|
Tesla.Mock.mock_global(fn env -> apply(HttpRequestMock, :request, [env]) end)
|
|
:ok
|
|
end
|
|
|
|
setup do: clear_config([:instance, :max_remote_account_fields])
|
|
|
|
describe "handle_incoming" do
|
|
test "it works for incoming unfollows with an existing follow" do
|
|
user = insert(:user)
|
|
|
|
follow_data =
|
|
File.read!("test/fixtures/mastodon-follow-activity.json")
|
|
|> Jason.decode!()
|
|
|> Map.put("object", user.ap_id)
|
|
|
|
{:ok, %Activity{data: _, local: false}} = Transmogrifier.handle_incoming(follow_data)
|
|
|
|
data =
|
|
File.read!("test/fixtures/mastodon-unfollow-activity.json")
|
|
|> Jason.decode!()
|
|
|> Map.put("object", follow_data)
|
|
|
|
{:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
|
|
|
|
assert data["type"] == "Undo"
|
|
assert data["object"]["type"] == "Follow"
|
|
assert data["object"]["object"] == user.ap_id
|
|
assert data["actor"] == "http://mastodon.example.org/users/admin"
|
|
|
|
refute User.following?(User.get_cached_by_ap_id(data["actor"]), user)
|
|
end
|
|
|
|
test "it accepts Flag activities" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "test post"})
|
|
object = Object.normalize(activity, fetch: false)
|
|
|
|
note_obj = %{
|
|
"type" => "Note",
|
|
"id" => activity.object.data["id"],
|
|
"content" => "test post",
|
|
"published" => object.data["published"],
|
|
"actor" => AccountView.render("show.json", %{user: user, skip_visibility_check: true})
|
|
}
|
|
|
|
message = %{
|
|
"@context" => "https://www.w3.org/ns/activitystreams",
|
|
"cc" => [user.ap_id],
|
|
"object" => [user.ap_id, activity.data["id"]],
|
|
"type" => "Flag",
|
|
"content" => "blocked AND reported!!!",
|
|
"actor" => other_user.ap_id
|
|
}
|
|
|
|
assert {:ok, activity} = Transmogrifier.handle_incoming(message)
|
|
|
|
assert activity.data["object"] == [user.ap_id, note_obj]
|
|
assert activity.data["content"] == "blocked AND reported!!!"
|
|
assert activity.data["actor"] == other_user.ap_id
|
|
assert activity.data["cc"] == [user.ap_id]
|
|
end
|
|
|
|
test "it rejects Flag activities when both reporter and reported account are remote" do
|
|
reporter = insert(:user, local: false, domain: "mastodon.cat")
|
|
reported = insert(:user, local: false, domain: "nicecrew.digital")
|
|
|
|
message = %{
|
|
"@context" => "https://www.w3.org/ns/activitystreams",
|
|
"actor" => reporter.ap_id,
|
|
"content" => "blocked AND reported!!!",
|
|
"object" => [reported.ap_id, "https://nicecrew.digital/objects/report-status"],
|
|
"type" => "Flag"
|
|
}
|
|
|
|
assert {:reject, reason} = Transmogrifier.handle_incoming(message)
|
|
assert reason =~ "third-party report"
|
|
refute "Flag" |> Pleroma.Activity.Queries.by_type() |> Pleroma.Repo.one()
|
|
end
|
|
|
|
test "it accepts Flag activities with just actor id as object" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
message = %{
|
|
"@context" => "https://www.w3.org/ns/activitystreams",
|
|
"cc" => [user.ap_id],
|
|
"object" => user.ap_id,
|
|
"type" => "Flag",
|
|
"content" => "blocked AND reported!!!",
|
|
"actor" => other_user.ap_id
|
|
}
|
|
|
|
assert {:ok, activity} = Transmogrifier.handle_incoming(message)
|
|
|
|
assert activity.data["content"] == "blocked AND reported!!!"
|
|
assert activity.data["actor"] == other_user.ap_id
|
|
assert activity.data["cc"] == [user.ap_id]
|
|
end
|
|
|
|
test "it accepts Move activities" do
|
|
old_user = insert(:user)
|
|
new_user = insert(:user)
|
|
|
|
message = %{
|
|
"@context" => "https://www.w3.org/ns/activitystreams",
|
|
"type" => "Move",
|
|
"actor" => old_user.ap_id,
|
|
"object" => old_user.ap_id,
|
|
"target" => new_user.ap_id
|
|
}
|
|
|
|
assert :error = Transmogrifier.handle_incoming(message)
|
|
|
|
{:ok, _new_user} = User.update_and_set_cache(new_user, %{also_known_as: [old_user.ap_id]})
|
|
|
|
assert {:ok, %Activity{} = activity} = Transmogrifier.handle_incoming(message)
|
|
assert activity.actor == old_user.ap_id
|
|
assert activity.data["actor"] == old_user.ap_id
|
|
assert activity.data["object"] == old_user.ap_id
|
|
assert activity.data["target"] == new_user.ap_id
|
|
assert activity.data["type"] == "Move"
|
|
end
|
|
|
|
test "it fixes both the Create and object contexts in a reply" do
|
|
insert(:user, ap_id: "https://mk.absturztau.be/users/8ozbzjs3o8")
|
|
insert(:user, ap_id: "https://p.helene.moe/users/helene")
|
|
|
|
create_activity =
|
|
"test/fixtures/create-pleroma-reply-to-misskey-thread.json"
|
|
|> File.read!()
|
|
|> Jason.decode!()
|
|
|
|
assert {:ok, %Activity{} = activity} = Transmogrifier.handle_incoming(create_activity)
|
|
|
|
object = Object.normalize(activity, fetch: false)
|
|
|
|
assert activity.data["context"] == object.data["context"]
|
|
end
|
|
|
|
test "it fixes the public scope addressing" do
|
|
insert(:user,
|
|
ap_id: "https://mymath.rocks/endpoints/SYn3cl_N4HAPfPHgo2x37XunLEmhV9LnxCggcYwyec0"
|
|
)
|
|
|
|
object =
|
|
"test/fixtures/bovine-bogus-public-note.json"
|
|
|> File.read!()
|
|
|> Jason.decode!()
|
|
|
|
message = %{
|
|
"@context" => "https://www.w3.org/ns/activitystreams",
|
|
"type" => "Create",
|
|
"actor" => "https://mymath.rocks/endpoints/SYn3cl_N4HAPfPHgo2x37XunLEmhV9LnxCggcYwyec0",
|
|
"object" => object
|
|
}
|
|
|
|
assert {:ok, activity} = Transmogrifier.handle_incoming(message)
|
|
|
|
object = Object.normalize(activity, fetch: false)
|
|
assert "https://www.w3.org/ns/activitystreams#Public" in activity.data["to"]
|
|
assert "https://www.w3.org/ns/activitystreams#Public" in object.data["to"]
|
|
end
|
|
|
|
test "it keeps link tags" do
|
|
insert(:user, ap_id: "https://example.org/users/alice")
|
|
|
|
message = File.read!("test/fixtures/fep-e232.json") |> Jason.decode!()
|
|
|
|
assert capture_log(fn ->
|
|
assert {:ok, activity} = Transmogrifier.handle_incoming(message)
|
|
object = Object.normalize(activity)
|
|
assert [%{"type" => "Mention"}, %{"type" => "Link"}] = object.data["tag"]
|
|
end) =~ "Object rejected while fetching"
|
|
end
|
|
|
|
test "it accepts quote posts" do
|
|
insert(:user, ap_id: "https://misskey.io/users/7rkrarq81i")
|
|
|
|
object = File.read!("test/fixtures/quote_post/misskey_quote_post.json") |> Jason.decode!()
|
|
|
|
message = %{
|
|
"@context" => "https://www.w3.org/ns/activitystreams",
|
|
"type" => "Create",
|
|
"actor" => "https://misskey.io/users/7rkrarq81i",
|
|
"object" => object
|
|
}
|
|
|
|
assert {:ok, activity} = Transmogrifier.handle_incoming(message)
|
|
|
|
# Object was created in the database
|
|
object = Object.normalize(activity)
|
|
assert object.data["quoteUrl"] == "https://misskey.io/notes/8vs6wxufd0"
|
|
|
|
# It fetched the quoted post
|
|
assert Object.normalize("https://misskey.io/notes/8vs6wxufd0")
|
|
end
|
|
|
|
test "doesn't allow remote edits to fake local likes" do
|
|
# as a spot check for no internal fields getting injected
|
|
now = DateTime.utc_now()
|
|
pub_date = DateTime.to_iso8601(Timex.subtract(now, Timex.Duration.from_minutes(3)))
|
|
edit_date = DateTime.to_iso8601(now)
|
|
|
|
local_user = insert(:user)
|
|
|
|
create_data = %{
|
|
"type" => "Create",
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/2619539638/activity",
|
|
"actor" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"cc" => [],
|
|
"object" => %{
|
|
"type" => "Note",
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/2619539638",
|
|
"attributedTo" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"cc" => [],
|
|
"published" => pub_date,
|
|
"content" => "miaow",
|
|
"likes" => [local_user.ap_id]
|
|
}
|
|
}
|
|
|
|
update_data =
|
|
create_data
|
|
|> Map.put("type", "Update")
|
|
|> Map.put("id", create_data["object"]["id"] <> "/update/1")
|
|
|> put_in(["object", "content"], "miaow :3")
|
|
|> put_in(["object", "updated"], edit_date)
|
|
|> put_in(["object", "formerRepresentations"], %{
|
|
"type" => "OrderedCollection",
|
|
"totalItems" => 1,
|
|
"orderedItems" => [create_data["object"]]
|
|
})
|
|
|
|
{:ok, %Pleroma.Activity{} = activity} = Transmogrifier.handle_incoming(create_data)
|
|
%Pleroma.Object{} = object = Object.get_by_ap_id(activity.data["object"])
|
|
assert object.data["content"] == "miaow"
|
|
assert object.data["likes"] == []
|
|
assert object.data["like_count"] == 0
|
|
|
|
{:ok, %Pleroma.Activity{} = activity} = Transmogrifier.handle_incoming(update_data)
|
|
%Pleroma.Object{} = object = Object.get_by_ap_id(activity.data["object"]["id"])
|
|
assert object.data["content"] == "miaow :3"
|
|
assert object.data["likes"] == []
|
|
assert object.data["like_count"] == 0
|
|
end
|
|
|
|
test "strips internal fields from history items in edited notes" do
|
|
now = DateTime.utc_now()
|
|
pub_date = DateTime.to_iso8601(Timex.subtract(now, Timex.Duration.from_minutes(3)))
|
|
edit_date = DateTime.to_iso8601(now)
|
|
|
|
local_user = insert(:user)
|
|
|
|
create_data = %{
|
|
"type" => "Create",
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/2619539638/activity",
|
|
"actor" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"cc" => [],
|
|
"object" => %{
|
|
"type" => "Note",
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/2619539638",
|
|
"attributedTo" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"cc" => [],
|
|
"published" => pub_date,
|
|
"content" => "miaow",
|
|
"likes" => [],
|
|
"like_count" => 0
|
|
}
|
|
}
|
|
|
|
update_data =
|
|
create_data
|
|
|> Map.put("type", "Update")
|
|
|> Map.put("id", create_data["object"]["id"] <> "/update/1")
|
|
|> put_in(["object", "content"], "miaow :3")
|
|
|> put_in(["object", "updated"], edit_date)
|
|
|> put_in(["object", "formerRepresentations"], %{
|
|
"type" => "OrderedCollection",
|
|
"totalItems" => 1,
|
|
"orderedItems" => [
|
|
Map.merge(create_data["object"], %{
|
|
"likes" => [local_user.ap_id],
|
|
"like_count" => 1,
|
|
"pleroma" => %{"internal_field" => "should_be_stripped"}
|
|
})
|
|
]
|
|
})
|
|
|
|
{:ok, %Pleroma.Activity{} = activity} = Transmogrifier.handle_incoming(create_data)
|
|
%Pleroma.Object{} = object = Object.get_by_ap_id(activity.data["object"])
|
|
assert object.data["content"] == "miaow"
|
|
assert object.data["likes"] == []
|
|
assert object.data["like_count"] == 0
|
|
|
|
{:ok, %Pleroma.Activity{} = activity} = Transmogrifier.handle_incoming(update_data)
|
|
%Pleroma.Object{} = object = Object.get_by_ap_id(activity.data["object"]["id"])
|
|
assert object.data["content"] == "miaow :3"
|
|
assert object.data["likes"] == []
|
|
assert object.data["like_count"] == 0
|
|
|
|
# Check that internal fields are stripped from history items
|
|
history_item = List.first(object.data["formerRepresentations"]["orderedItems"])
|
|
assert history_item["likes"] == []
|
|
assert history_item["like_count"] == 0
|
|
refute Map.has_key?(history_item, "pleroma")
|
|
end
|
|
|
|
test "doesn't trip over remote likes in notes" do
|
|
now = DateTime.utc_now()
|
|
pub_date = DateTime.to_iso8601(Timex.subtract(now, Timex.Duration.from_minutes(3)))
|
|
edit_date = DateTime.to_iso8601(now)
|
|
|
|
create_data = %{
|
|
"type" => "Create",
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/3409297097/activity",
|
|
"actor" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"cc" => [],
|
|
"object" => %{
|
|
"type" => "Note",
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/3409297097",
|
|
"attributedTo" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"cc" => [],
|
|
"published" => pub_date,
|
|
"content" => "miaow",
|
|
"likes" => %{
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/3409297097/likes",
|
|
"totalItems" => 0,
|
|
"type" => "Collection"
|
|
}
|
|
}
|
|
}
|
|
|
|
update_data =
|
|
create_data
|
|
|> Map.put("type", "Update")
|
|
|> Map.put("id", create_data["object"]["id"] <> "/update/1")
|
|
|> put_in(["object", "content"], "miaow :3")
|
|
|> put_in(["object", "updated"], edit_date)
|
|
|> put_in(["object", "likes", "totalItems"], 666)
|
|
|> put_in(["object", "formerRepresentations"], %{
|
|
"type" => "OrderedCollection",
|
|
"totalItems" => 1,
|
|
"orderedItems" => [create_data["object"]]
|
|
})
|
|
|
|
{:ok, %Pleroma.Activity{} = activity} = Transmogrifier.handle_incoming(create_data)
|
|
%Pleroma.Object{} = object = Object.get_by_ap_id(activity.data["object"])
|
|
assert object.data["content"] == "miaow"
|
|
assert object.data["likes"] == []
|
|
assert object.data["like_count"] == 0
|
|
|
|
{:ok, %Pleroma.Activity{} = activity} = Transmogrifier.handle_incoming(update_data)
|
|
%Pleroma.Object{} = object = Object.get_by_ap_id(activity.data["object"]["id"])
|
|
assert object.data["content"] == "miaow :3"
|
|
assert object.data["likes"] == []
|
|
# in the future this should retain remote likes, but for now:
|
|
assert object.data["like_count"] == 0
|
|
end
|
|
|
|
test "doesn't trip over remote likes in polls" do
|
|
now = DateTime.utc_now()
|
|
pub_date = DateTime.to_iso8601(Timex.subtract(now, Timex.Duration.from_minutes(3)))
|
|
edit_date = DateTime.to_iso8601(now)
|
|
|
|
create_data = %{
|
|
"type" => "Create",
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/2471790073/activity",
|
|
"actor" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"cc" => [],
|
|
"object" => %{
|
|
"type" => "Question",
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/2471790073",
|
|
"attributedTo" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"cc" => [],
|
|
"published" => pub_date,
|
|
"content" => "vote!",
|
|
"anyOf" => [
|
|
%{
|
|
"type" => "Note",
|
|
"name" => "a",
|
|
"replies" => %{
|
|
"type" => "Collection",
|
|
"totalItems" => 3
|
|
}
|
|
},
|
|
%{
|
|
"type" => "Note",
|
|
"name" => "b",
|
|
"replies" => %{
|
|
"type" => "Collection",
|
|
"totalItems" => 1
|
|
}
|
|
}
|
|
],
|
|
"likes" => %{
|
|
"id" => "http://mastodon.example.org/users/admin/statuses/2471790073/likes",
|
|
"totalItems" => 0,
|
|
"type" => "Collection"
|
|
}
|
|
}
|
|
}
|
|
|
|
update_data =
|
|
create_data
|
|
|> Map.put("type", "Update")
|
|
|> Map.put("id", create_data["object"]["id"] <> "/update/1")
|
|
|> put_in(["object", "content"], "vote now!")
|
|
|> put_in(["object", "updated"], edit_date)
|
|
|> put_in(["object", "likes", "totalItems"], 666)
|
|
|> put_in(["object", "formerRepresentations"], %{
|
|
"type" => "OrderedCollection",
|
|
"totalItems" => 1,
|
|
"orderedItems" => [create_data["object"]]
|
|
})
|
|
|
|
{:ok, %Pleroma.Activity{} = activity} = Transmogrifier.handle_incoming(create_data)
|
|
%Pleroma.Object{} = object = Object.get_by_ap_id(activity.data["object"])
|
|
assert object.data["content"] == "vote!"
|
|
assert object.data["likes"] == []
|
|
assert object.data["like_count"] == 0
|
|
|
|
{:ok, %Pleroma.Activity{} = activity} = Transmogrifier.handle_incoming(update_data)
|
|
%Pleroma.Object{} = object = Object.get_by_ap_id(activity.data["object"]["id"])
|
|
assert object.data["content"] == "vote now!"
|
|
assert object.data["likes"] == []
|
|
# in the future this should retain remote likes, but for now:
|
|
assert object.data["like_count"] == 0
|
|
end
|
|
end
|
|
|
|
describe "prepare outgoing" do
|
|
test "it inlines private announced objects" do
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "hey", visibility: "private"})
|
|
|
|
{:ok, announce_activity} = CommonAPI.repeat(activity.id, user)
|
|
|
|
{:ok, modified} = Transmogrifier.prepare_activity(announce_activity.data)
|
|
|
|
assert modified["object"]["content"] == "hey"
|
|
assert modified["object"]["actor"] == modified["object"]["attributedTo"]
|
|
end
|
|
|
|
test "it turns mentions into tags" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} =
|
|
CommonAPI.post(user, %{status: "hey, @#{other_user.nickname}, how are ya? #2hu"})
|
|
|
|
with_mock Pleroma.Notification,
|
|
get_notified_from_activity: fn _, _ -> [] end do
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
object = modified["object"]
|
|
|
|
expected_mention = %{
|
|
"href" => other_user.ap_id,
|
|
"name" => "@#{other_user.nickname}",
|
|
"type" => "Mention"
|
|
}
|
|
|
|
expected_tag = %{
|
|
"href" => Pleroma.Web.Endpoint.url() <> "/tags/2hu",
|
|
"type" => "Hashtag",
|
|
"name" => "#2hu"
|
|
}
|
|
|
|
refute called(Pleroma.Notification.get_notified_from_activity(:_, :_))
|
|
assert Enum.member?(object["tag"], expected_tag)
|
|
assert Enum.member?(object["tag"], expected_mention)
|
|
end
|
|
end
|
|
|
|
test "it adds the json-ld context and the conversation property" do
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "hey"})
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert modified["@context"] == Utils.make_json_ld_header()["@context"]
|
|
|
|
assert modified["object"]["conversation"] == modified["context"]
|
|
end
|
|
|
|
test "it sets the 'attributedTo' property to the actor of the object if it doesn't have one" do
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "hey"})
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert modified["object"]["actor"] == modified["object"]["attributedTo"]
|
|
end
|
|
|
|
test "it strips internal hashtag data" do
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "#2hu"})
|
|
|
|
expected_tag = %{
|
|
"href" => Pleroma.Web.Endpoint.url() <> "/tags/2hu",
|
|
"type" => "Hashtag",
|
|
"name" => "#2hu"
|
|
}
|
|
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert modified["object"]["tag"] == [expected_tag]
|
|
end
|
|
|
|
test "it strips internal fields" do
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} =
|
|
CommonAPI.post(user, %{
|
|
status: "#2hu :firefox:",
|
|
generator: %{type: "Application", name: "TestClient", url: "https://pleroma.social"}
|
|
})
|
|
|
|
# Ensure injected application data made it into the activity
|
|
# as we don't have a Token to derive it from, otherwise it will
|
|
# be nil and the test will pass
|
|
assert %{
|
|
type: "Application",
|
|
name: "TestClient",
|
|
url: "https://pleroma.social"
|
|
} == activity.object.data["generator"]
|
|
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert length(modified["object"]["tag"]) == 2
|
|
|
|
assert is_nil(modified["object"]["emoji"])
|
|
assert is_nil(modified["object"]["like_count"])
|
|
assert is_nil(modified["object"]["announcements"])
|
|
assert is_nil(modified["object"]["announcement_count"])
|
|
assert is_nil(modified["object"]["generator"])
|
|
assert is_nil(modified["object"]["rules"])
|
|
assert is_nil(modified["object"]["language"])
|
|
assert is_nil(modified["object"]["voters"])
|
|
end
|
|
|
|
test "it strips internal fields of article" do
|
|
activity = insert(:article_activity)
|
|
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert length(modified["object"]["tag"]) == 2
|
|
|
|
assert is_nil(modified["object"]["emoji"])
|
|
assert is_nil(modified["object"]["like_count"])
|
|
assert is_nil(modified["object"]["announcements"])
|
|
assert is_nil(modified["object"]["announcement_count"])
|
|
assert is_nil(modified["object"]["likes"])
|
|
end
|
|
|
|
test "the directMessage flag is present" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "2hu :moominmamma:"})
|
|
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert modified["directMessage"] == false
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "@#{other_user.nickname} :moominmamma:"})
|
|
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert modified["directMessage"] == false
|
|
|
|
{:ok, activity} =
|
|
CommonAPI.post(user, %{
|
|
status: "@#{other_user.nickname} :moominmamma:",
|
|
visibility: "direct"
|
|
})
|
|
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert modified["directMessage"] == true
|
|
end
|
|
|
|
test "it strips BCC field" do
|
|
user = insert(:user)
|
|
{:ok, list} = Pleroma.List.create(%{title: "foo"}, user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "foobar", visibility: "list:#{list.id}"})
|
|
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert is_nil(modified["bcc"])
|
|
end
|
|
|
|
test "it can handle Listen activities" do
|
|
listen_activity = insert(:listen)
|
|
|
|
# This has an inlined object as in ObjectView
|
|
{:ok, modified} = Transmogrifier.prepare_activity(listen_activity.data)
|
|
|
|
assert modified["type"] == "Listen"
|
|
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.listen(user, %{"title" => "lain radio episode 1"})
|
|
|
|
user_ap_id = user.ap_id
|
|
activity_ap_id = activity.data["id"]
|
|
activity_to = activity.data["to"]
|
|
activity_cc = activity.data["cc"]
|
|
object_ap_id = activity.data["object"]
|
|
object_type = activity.object.data["type"]
|
|
|
|
# This does not have an inlined object
|
|
{:ok, modified2} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert match?(
|
|
%{
|
|
"@context" => [_ | _],
|
|
"type" => "Listen",
|
|
"actor" => ^user_ap_id,
|
|
"to" => ^activity_to,
|
|
"cc" => ^activity_cc,
|
|
"context" => "http://localhost" <> _,
|
|
"id" => ^activity_ap_id,
|
|
"object" => %{
|
|
"actor" => ^user_ap_id,
|
|
"attributedTo" => ^user_ap_id,
|
|
"id" => ^object_ap_id,
|
|
"type" => ^object_type,
|
|
"to" => ^activity_to,
|
|
"cc" => ^activity_cc
|
|
}
|
|
},
|
|
modified2
|
|
)
|
|
end
|
|
|
|
test "custom emoji urls are URI encoded" do
|
|
# :dinosaur: filename has a space -> dino walking.gif
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "everybody do the dinosaur :dinosaur:"})
|
|
|
|
{:ok, prepared} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert length(prepared["object"]["tag"]) == 1
|
|
|
|
url = prepared["object"]["tag"] |> List.first() |> Map.get("icon") |> Map.get("url")
|
|
|
|
assert url == "http://localhost:4001/emoji/dino%20walking.gif"
|
|
end
|
|
|
|
test "Updates of Notes are handled" do
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "everybody do the dinosaur :dinosaur:"})
|
|
{:ok, update} = CommonAPI.update(activity, user, %{status: "mew mew :blank:"})
|
|
|
|
{:ok, prepared} = Transmogrifier.prepare_activity(update.data)
|
|
|
|
assert %{
|
|
"content" => "mew mew :blank:",
|
|
"tag" => [%{"name" => ":blank:", "type" => "Emoji"}],
|
|
"formerRepresentations" => %{
|
|
"orderedItems" => [
|
|
%{
|
|
"content" => "everybody do the dinosaur :dinosaur:",
|
|
"tag" => [%{"name" => ":dinosaur:", "type" => "Emoji"}]
|
|
}
|
|
]
|
|
}
|
|
} = prepared["object"]
|
|
end
|
|
|
|
test "Updates of Actors are handled" do
|
|
user = insert(:user, local: true)
|
|
|
|
changeset = User.update_changeset(user, %{name: "new name"})
|
|
{:ok, unpersisted_user} = Ecto.Changeset.apply_action(changeset, :update)
|
|
|
|
updated_object =
|
|
UserView.render("user.json", user: unpersisted_user)
|
|
|> Map.delete("@context")
|
|
|
|
{:ok, update_data, []} = Builder.update(user, updated_object)
|
|
|
|
{:ok, activity, _} =
|
|
Pipeline.common_pipeline(update_data,
|
|
local: true,
|
|
user_update_changeset: changeset
|
|
)
|
|
|
|
assert {:ok, prepared} = Transmogrifier.prepare_activity(activity.data)
|
|
assert prepared["type"] == "Update"
|
|
assert prepared["@context"]
|
|
assert prepared["object"]["type"] == user.actor_type
|
|
end
|
|
|
|
test "Correctly handles Undo activities" do
|
|
blocked = insert(:user)
|
|
blocker = insert(:user, local: true)
|
|
|
|
blocked_ap_id = blocked.ap_id
|
|
blocker_ap_id = blocker.ap_id
|
|
|
|
{:ok, %Activity{} = block_activity} = CommonAPI.block(blocked, blocker)
|
|
{:ok, %Activity{} = undo_activity} = CommonAPI.unblock(blocked, blocker)
|
|
{:ok, data} = Transmogrifier.prepare_activity(undo_activity.data)
|
|
|
|
block_ap_id = block_activity.data["id"]
|
|
assert is_binary(block_ap_id)
|
|
|
|
assert match?(
|
|
%{
|
|
"@context" => [_ | _],
|
|
"type" => "Undo",
|
|
"id" => "http://localhost" <> _,
|
|
"actor" => ^blocker_ap_id,
|
|
"object" => ^block_ap_id,
|
|
"to" => [^blocked_ap_id],
|
|
"cc" => [],
|
|
"bto" => [],
|
|
"bcc" => []
|
|
},
|
|
data
|
|
)
|
|
end
|
|
|
|
test "Correctly handles EmojiReact activities" do
|
|
user = insert(:user, local: true)
|
|
note_activity = insert(:note_activity)
|
|
|
|
user_ap_id = user.ap_id
|
|
user_followers = user.follower_address
|
|
note_author = note_activity.data["actor"]
|
|
note_ap_id = note_activity.data["object"]
|
|
|
|
assert is_binary(note_author)
|
|
assert is_binary(note_ap_id)
|
|
|
|
{:ok, react_activity} = CommonAPI.react_with_emoji(note_activity.id, user, "🐈")
|
|
{:ok, data} = Transmogrifier.prepare_activity(react_activity.data)
|
|
|
|
assert match?(
|
|
%{
|
|
"@context" => [_ | _],
|
|
"type" => "EmojiReact",
|
|
"actor" => ^user_ap_id,
|
|
"to" => [^user_followers, ^note_author],
|
|
"cc" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"bto" => [],
|
|
"bcc" => [],
|
|
"content" => "🐈",
|
|
"context" => "2hu",
|
|
"id" => "http://localhost" <> _,
|
|
"object" => ^note_ap_id,
|
|
"tag" => []
|
|
},
|
|
data
|
|
)
|
|
end
|
|
|
|
test "EmojiReact custom emoji urls are URI encoded" do
|
|
user = insert(:user, local: true)
|
|
note_activity = insert(:note_activity)
|
|
|
|
{:ok, react_activity} = CommonAPI.react_with_emoji(note_activity.id, user, ":dinosaur:")
|
|
{:ok, data} = Transmogrifier.prepare_activity(react_activity.data)
|
|
|
|
assert length(data["tag"]) == 1
|
|
|
|
tag = List.first(data["tag"])
|
|
url = tag["icon"]["url"]
|
|
|
|
assert url == "http://localhost:4001/emoji/dino%20walking.gif"
|
|
assert tag["id"] == "http://localhost:4001/emoji/dino%20walking.gif"
|
|
end
|
|
|
|
test "it prepares a quote post" do
|
|
user = insert(:user)
|
|
|
|
{:ok, quoted_post} = CommonAPI.post(user, %{status: "hey"})
|
|
{:ok, quote_post} = CommonAPI.post(user, %{status: "hey", quoted_status_id: quoted_post.id})
|
|
|
|
{:ok, modified} = Transmogrifier.prepare_activity(quote_post.data)
|
|
|
|
%{data: %{"id" => quote_id}} = Object.normalize(quoted_post)
|
|
|
|
assert modified["object"]["quoteUrl"] == quote_id
|
|
assert modified["object"]["quoteUri"] == quote_id
|
|
end
|
|
|
|
test "it adds language of the object to its json-ld context" do
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "Cześć", language: "pl"})
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.object.data)
|
|
|
|
assert [_, _, %{"@language" => "pl"}] = modified["@context"]
|
|
end
|
|
|
|
test "it adds language of the object to Create activity json-ld context" do
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "Cześć", language: "pl"})
|
|
{:ok, modified} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
assert [_, _, %{"@language" => "pl"}] = modified["@context"]
|
|
end
|
|
|
|
test "it strips report data" do
|
|
reporter = insert(:user)
|
|
target_account = insert(:user)
|
|
content = "foobar"
|
|
{:ok, reported_activity} = CommonAPI.post(target_account, %{status: content})
|
|
context = Utils.generate_context_id()
|
|
|
|
object_ap_id = reported_activity.object.data["id"]
|
|
|
|
assert {:ok, activity} =
|
|
Pleroma.Web.ActivityPub.ActivityPub.flag(%{
|
|
actor: reporter,
|
|
context: context,
|
|
account: target_account,
|
|
statuses: [reported_activity],
|
|
content: content
|
|
})
|
|
|
|
{:ok, data} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
expected_data =
|
|
activity.data
|
|
|> put_in(["object"], [target_account.ap_id, object_ap_id])
|
|
|> Map.put("actor", reporter.ap_id)
|
|
|> Map.merge(Utils.make_json_ld_header())
|
|
|
|
assert data == expected_data
|
|
end
|
|
|
|
test "it strips report data and anonymize" do
|
|
placeholder = insert(:user)
|
|
|
|
reporter = insert(:user)
|
|
target_account = insert(:user)
|
|
content = "foobar"
|
|
{:ok, reported_activity} = CommonAPI.post(target_account, %{status: content})
|
|
context = Utils.generate_context_id()
|
|
|
|
object_ap_id = reported_activity.object.data["id"]
|
|
|
|
assert {:ok, activity} =
|
|
Pleroma.Web.ActivityPub.ActivityPub.flag(%{
|
|
actor: reporter,
|
|
context: context,
|
|
account: target_account,
|
|
statuses: [reported_activity],
|
|
content: content
|
|
})
|
|
|
|
clear_config([:activitypub, :anonymize_reporter], true)
|
|
clear_config([:activitypub, :anonymize_reporter_local_nickname], placeholder.nickname)
|
|
|
|
{:ok, data} = Transmogrifier.prepare_activity(activity.data)
|
|
|
|
expected_data =
|
|
activity.data
|
|
|> put_in(["object"], [target_account.ap_id, object_ap_id])
|
|
|> Map.put("actor", placeholder.ap_id)
|
|
|> Map.merge(Utils.make_json_ld_header())
|
|
|
|
assert data == expected_data
|
|
end
|
|
end
|
|
|
|
describe "actor rewriting" do
|
|
test "it fixes the actor URL property to be a proper URI" do
|
|
data = %{
|
|
"url" => %{"href" => "http://example.com"}
|
|
}
|
|
|
|
rewritten = Transmogrifier.maybe_fix_user_object(data)
|
|
assert rewritten["url"] == "http://example.com"
|
|
end
|
|
end
|
|
|
|
describe "actor origin containment" do
|
|
test "it rejects activities which reference objects with bogus origins" do
|
|
data = %{
|
|
"@context" => "https://www.w3.org/ns/activitystreams",
|
|
"id" => "http://mastodon.example.org/users/admin/activities/1234",
|
|
"actor" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"object" => "https://info.pleroma.site/activity.json",
|
|
"type" => "Announce"
|
|
}
|
|
|
|
assert capture_log(fn ->
|
|
{:error, _} = Transmogrifier.handle_incoming(data)
|
|
end) =~ "Object rejected while fetching"
|
|
end
|
|
|
|
test "it rejects activities which reference objects that have an incorrect attribution (variant 1)" do
|
|
data = %{
|
|
"@context" => "https://www.w3.org/ns/activitystreams",
|
|
"id" => "http://mastodon.example.org/users/admin/activities/1234",
|
|
"actor" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"object" => "https://info.pleroma.site/activity2.json",
|
|
"type" => "Announce"
|
|
}
|
|
|
|
assert capture_log(fn ->
|
|
{:error, _} = Transmogrifier.handle_incoming(data)
|
|
end) =~ "Object rejected while fetching"
|
|
end
|
|
|
|
test "it rejects activities which reference objects that have an incorrect attribution (variant 2)" do
|
|
data = %{
|
|
"@context" => "https://www.w3.org/ns/activitystreams",
|
|
"id" => "http://mastodon.example.org/users/admin/activities/1234",
|
|
"actor" => "http://mastodon.example.org/users/admin",
|
|
"to" => ["https://www.w3.org/ns/activitystreams#Public"],
|
|
"object" => "https://info.pleroma.site/activity3.json",
|
|
"type" => "Announce"
|
|
}
|
|
|
|
assert capture_log(fn ->
|
|
{:error, _} = Transmogrifier.handle_incoming(data)
|
|
end) =~ "Object rejected while fetching"
|
|
end
|
|
end
|
|
|
|
describe "fix_explicit_addressing" do
|
|
setup do
|
|
user = insert(:user)
|
|
[user: user]
|
|
end
|
|
|
|
test "moves non-explicitly mentioned actors to cc", %{user: user} do
|
|
explicitly_mentioned_actors = [
|
|
"https://pleroma.gold/users/user1",
|
|
"https://pleroma.gold/user2"
|
|
]
|
|
|
|
object = %{
|
|
"actor" => user.ap_id,
|
|
"to" => explicitly_mentioned_actors ++ ["https://social.beepboop.ga/users/dirb"],
|
|
"cc" => [],
|
|
"tag" =>
|
|
Enum.map(explicitly_mentioned_actors, fn href ->
|
|
%{"type" => "Mention", "href" => href}
|
|
end)
|
|
}
|
|
|
|
fixed_object = Transmogrifier.fix_explicit_addressing(object, user.follower_address)
|
|
assert Enum.all?(explicitly_mentioned_actors, &(&1 in fixed_object["to"]))
|
|
refute "https://social.beepboop.ga/users/dirb" in fixed_object["to"]
|
|
assert "https://social.beepboop.ga/users/dirb" in fixed_object["cc"]
|
|
end
|
|
|
|
test "does not move actor's follower collection to cc", %{user: user} do
|
|
object = %{
|
|
"actor" => user.ap_id,
|
|
"to" => [user.follower_address],
|
|
"cc" => []
|
|
}
|
|
|
|
fixed_object = Transmogrifier.fix_explicit_addressing(object, user.follower_address)
|
|
assert user.follower_address in fixed_object["to"]
|
|
refute user.follower_address in fixed_object["cc"]
|
|
end
|
|
|
|
test "removes recipient's follower collection from cc", %{user: user} do
|
|
recipient = insert(:user)
|
|
|
|
object = %{
|
|
"actor" => user.ap_id,
|
|
"to" => [recipient.ap_id, "https://www.w3.org/ns/activitystreams#Public"],
|
|
"cc" => [user.follower_address, recipient.follower_address]
|
|
}
|
|
|
|
fixed_object = Transmogrifier.fix_explicit_addressing(object, user.follower_address)
|
|
|
|
assert user.follower_address in fixed_object["cc"]
|
|
refute recipient.follower_address in fixed_object["cc"]
|
|
refute recipient.follower_address in fixed_object["to"]
|
|
end
|
|
end
|
|
|
|
describe "fix_summary/1" do
|
|
test "returns fixed object" do
|
|
assert Transmogrifier.fix_summary(%{"summary" => nil}) == %{"summary" => ""}
|
|
assert Transmogrifier.fix_summary(%{"summary" => "ok"}) == %{"summary" => "ok"}
|
|
assert Transmogrifier.fix_summary(%{}) == %{"summary" => ""}
|
|
end
|
|
end
|
|
|
|
describe "fix_url/1" do
|
|
test "fixes data for object when url is map" do
|
|
object = %{
|
|
"url" => %{
|
|
"type" => "Link",
|
|
"mimeType" => "video/mp4",
|
|
"href" => "https://peede8d-46fb-ad81-2d4c2d1630e3-480.mp4"
|
|
}
|
|
}
|
|
|
|
assert Transmogrifier.fix_url(object) == %{
|
|
"url" => "https://peede8d-46fb-ad81-2d4c2d1630e3-480.mp4"
|
|
}
|
|
end
|
|
|
|
test "returns non-modified object" do
|
|
assert Transmogrifier.fix_url(%{"type" => "Text"}) == %{"type" => "Text"}
|
|
end
|
|
end
|
|
|
|
describe "get_obj_helper/2" do
|
|
test "returns nil when cannot normalize object" do
|
|
assert capture_log(fn ->
|
|
refute Transmogrifier.get_obj_helper("test-obj-id")
|
|
end) =~ "Unsupported URI scheme"
|
|
end
|
|
|
|
test "returns {:ok, %Object{}} for success case" do
|
|
assert {:ok, %Object{}} =
|
|
Transmogrifier.get_obj_helper(
|
|
"https://mstdn.io/users/mayuutann/statuses/99568293732299394"
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "fix_attachments/1" do
|
|
test "puts dimensions into attachment url field" do
|
|
object = %{
|
|
"attachment" => [
|
|
%{
|
|
"type" => "Document",
|
|
"name" => "Hello world",
|
|
"url" => "https://media.example.tld/1.jpg",
|
|
"width" => 880,
|
|
"height" => 960,
|
|
"mediaType" => "image/jpeg",
|
|
"blurhash" => "eTKL26+HDjcEIBVl;ds+K6t301W.t7nit7y1E,R:v}ai4nXSt7V@of"
|
|
}
|
|
]
|
|
}
|
|
|
|
expected = %{
|
|
"attachment" => [
|
|
%{
|
|
"type" => "Document",
|
|
"name" => "Hello world",
|
|
"url" => [
|
|
%{
|
|
"type" => "Link",
|
|
"mediaType" => "image/jpeg",
|
|
"href" => "https://media.example.tld/1.jpg",
|
|
"width" => 880,
|
|
"height" => 960
|
|
}
|
|
],
|
|
"mediaType" => "image/jpeg",
|
|
"blurhash" => "eTKL26+HDjcEIBVl;ds+K6t301W.t7nit7y1E,R:v}ai4nXSt7V@of"
|
|
}
|
|
]
|
|
}
|
|
|
|
assert Transmogrifier.fix_attachments(object) == expected
|
|
end
|
|
end
|
|
|
|
describe "prepare_object/1" do
|
|
test "it processes history" do
|
|
original = %{
|
|
"formerRepresentations" => %{
|
|
"orderedItems" => [
|
|
%{
|
|
"generator" => %{},
|
|
"emoji" => %{"blobcat" => "http://localhost:4001/emoji/blobcat.png"}
|
|
}
|
|
]
|
|
}
|
|
}
|
|
|
|
processed = Transmogrifier.prepare_object(original)
|
|
|
|
history_item = Enum.at(processed["formerRepresentations"]["orderedItems"], 0)
|
|
|
|
refute Map.has_key?(history_item, "generator")
|
|
|
|
assert [%{"name" => ":blobcat:"}] = history_item["tag"]
|
|
end
|
|
|
|
test "it works when there is no or bad history" do
|
|
original = %{
|
|
"formerRepresentations" => %{
|
|
"items" => [
|
|
%{
|
|
"generator" => %{},
|
|
"emoji" => %{"blobcat" => "http://localhost:4001/emoji/blobcat.png"}
|
|
}
|
|
]
|
|
}
|
|
}
|
|
|
|
processed = Transmogrifier.prepare_object(original)
|
|
assert processed["formerRepresentations"] == original["formerRepresentations"]
|
|
end
|
|
|
|
test "it uses contentMap to specify post language" do
|
|
user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(user, %{status: "Cześć", language: "pl"})
|
|
object = Transmogrifier.prepare_object(activity.object.data)
|
|
|
|
assert %{"contentMap" => %{"pl" => "Cześć"}} = object
|
|
end
|
|
end
|
|
end
|