[#2301] Quick fix: users with is_discoverable == false (default!) are included in search results.

test/pleroma/user_search_test.exs

@@ -65,12 +65,13 @@ defmodule Pleroma.UserSearchTest do
       assert found_user.id == user.id
     end
 
-    test "excludes users when discoverable is false" do
+    # NOTE: as long as users are non-discoverable by default, we can't filter out most users: #2301
+    test "does NOT exclude non-discoverable users from results (as long as it's the default)" do
       insert(:user, %{nickname: "john 3000", is_discoverable: false})
       insert(:user, %{nickname: "john 3001"})
 
       users = User.search("john")
-      assert Enum.count(users) == 1
+      assert Enum.count(users) == 2
     end
 
     test "excludes service actors from results" do