hj/pleroma
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix dialyzer error in object fetcher: Add proper guard clause for check_crossdomain_redirect/2

Browse source 
Also remove unnecessary and incorrect usage of Mix.env()
This commit is contained in:
Mark Felder 2025-07-22 11:50:28 -07:00
commit e0104132a7
1 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/pleroma/object/fetcher.ex
View file

@ -19,8 +19,6 @@ defmodule Pleroma.Object.Fetcher do
require Logger
require Pleroma.Constants
@mix_env Mix.env()
@spec reinject_object(struct(), map()) :: {:ok, Object.t()} | {:error, any()}
defp reinject_object(%Object{data: %{}} = object, new_data) do
Logger.debug("Reinjecting object #{new_data["id"]}")
@ -178,13 +176,8 @@ defmodule Pleroma.Object.Fetcher do
def fetch_and_contain_remote_object_from_id(_id),
do: {:error, "id must be a string"}
defp check_crossdomain_redirect(final_host, original_url)
# Handle the common case in tests where responses don't include URLs
if @mix_env == :test do
defp check_crossdomain_redirect(nil, _) do
{:cross_domain_redirect, false}
end
defp check_crossdomain_redirect(final_host, _original_url) when is_nil(final_host) do
{:cross_domain_redirect, false}
end
defp check_crossdomain_redirect(final_host, original_url) do