From df375662d661f2d8b311255f0eb8f209655e0393 Mon Sep 17 00:00:00 2001 From: Phantasm Date: Tue, 23 Dec 2025 17:04:08 +0100 Subject: [PATCH] AP: simplify visible_for_user? conditions. `true or true` returns `true` --- lib/pleroma/web/activity_pub/visibility.ex | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/pleroma/web/activity_pub/visibility.ex b/lib/pleroma/web/activity_pub/visibility.ex index b393947fe..903804d0d 100644 --- a/lib/pleroma/web/activity_pub/visibility.ex +++ b/lib/pleroma/web/activity_pub/visibility.ex @@ -73,7 +73,7 @@ defmodule Pleroma.Web.ActivityPub.Visibility do |> Pleroma.List.member?(user) end - def visible_for_user?(%Activity{data: _, object: %Object{data: _} = object} = activity, nil) do + def visible_for_user?(%Activity{object: %Object{} = object} = activity, nil) do activity_visibility? = restrict_unauthenticated_access?(activity) activity_public? = public?(activity) and not local_public?(activity) object_visibility? = restrict_unauthenticated_access?(object) @@ -81,9 +81,6 @@ defmodule Pleroma.Web.ActivityPub.Visibility do # Activity could be local, but object might not (Announce/Like) cond do - activity_visibility? == true and object_visibility? == true -> - false - activity_visibility? or object_visibility? -> false