hj/pleroma
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't crash when email settings are invalid

Browse source 
Fixes: https://git.pleroma.social/pleroma/pleroma/-/issues/2606
Fixes: https://gitlab.com/soapbox-pub/soapbox/-/issues/4
This commit is contained in:
Alex Gleason 2021-05-03 14:27:03 -05:00
commit c80b1aaf51
No known key found for this signature in database
GPG key ID: 7211D1F99744FBB7
3 changed files with 47 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

18
test/pleroma/user_test.exs
View file

@ -572,6 +572,24 @@ defmodule Pleroma.UserTest do
)
end
test "it fails gracefully with invalid email config" do
cng = User.register_changeset(%User{}, @full_user_data)
# Disable the mailer but enable all the things that want to send emails
clear_config([Pleroma.Emails.Mailer, :enabled], false)
clear_config([:instance, :account_activation_required], true)
clear_config([:instance, :account_approval_required], true)
clear_config([:welcome, :email, :enabled], true)
clear_config([:welcome, :email, :sender], "lain@lain.com")
# The user is still created
assert {:ok, %User{nickname: "nick"}} = User.register(cng)
# No emails are sent
ObanHelpers.perform_all()
refute_email_sent()
end
test "it requires an email, name, nickname and password, bio is optional when account_activation_required is enabled" do
clear_config([:instance, :account_activation_required], true)