Elixir 1.19: Fix most MRFs being absent from AdminAPI suggestions.
Elixir 1.19 started lazily loading modules, so modules only get loaded when referenced. Thus :code.all_loaded would no longer include all MRF policies which is used on startup to generate sugestions for AdminAPI.
This commit is contained in:
parent
4fe802b25a
commit
9782bcf979
1 changed files with 18 additions and 5 deletions
|
|
@ -12,13 +12,27 @@ defmodule Pleroma.Docs.Generator do
|
||||||
|
|
||||||
@spec list_behaviour_implementations(behaviour :: module()) :: [module()]
|
@spec list_behaviour_implementations(behaviour :: module()) :: [module()]
|
||||||
def list_behaviour_implementations(behaviour) do
|
def list_behaviour_implementations(behaviour) do
|
||||||
:code.all_loaded()
|
# :code.all_loaded() no longer works on Elixir 1.19 and newer since modules are lazily loaded.
|
||||||
|> Enum.filter(fn {module, _} ->
|
# We can get a complete list of modules by interating over Application.loaded_applications/0,
|
||||||
|
# but that includes every module which would get loaded below, which is very slow.
|
||||||
|
# Hardcode the Pleroma application instead, which is good enough for now.
|
||||||
|
application_modules =
|
||||||
|
case :application.get_key(:pleroma, :modules) do
|
||||||
|
{:ok, modules} -> modules
|
||||||
|
:undefined -> []
|
||||||
|
end
|
||||||
|
|
||||||
|
# At compile time or in tests some modules will be outside of the Pleroma application.
|
||||||
|
loaded_modules = Enum.map(:code.all_loaded(), fn {module, _} -> module end)
|
||||||
|
|
||||||
|
(application_modules ++ loaded_modules)
|
||||||
|
|> Enum.uniq()
|
||||||
|
|> Enum.filter(fn module ->
|
||||||
|
Code.ensure_loaded(module)
|
||||||
|
|
||||||
# This shouldn't be needed as all modules are expected to have module_info/1,
|
# This shouldn't be needed as all modules are expected to have module_info/1,
|
||||||
# but in test environments some transient modules `:elixir_compiler_XX`
|
# but in test environments some transient modules `:elixir_compiler_XX`
|
||||||
# are loaded for some reason (where XX is a random integer).
|
# are loaded for some reason (where XX is a random integer).
|
||||||
Code.ensure_loaded(module)
|
|
||||||
|
|
||||||
if function_exported?(module, :module_info, 1) do
|
if function_exported?(module, :module_info, 1) do
|
||||||
module.module_info(:attributes)
|
module.module_info(:attributes)
|
||||||
|> Keyword.get_values(:behaviour)
|
|> Keyword.get_values(:behaviour)
|
||||||
|
|
@ -26,7 +40,6 @@ defmodule Pleroma.Docs.Generator do
|
||||||
|> Enum.member?(behaviour)
|
|> Enum.member?(behaviour)
|
||||||
end
|
end
|
||||||
end)
|
end)
|
||||||
|> Enum.map(fn {module, _} -> module end)
|
|
||||||
end
|
end
|
||||||
|
|
||||||
@doc """
|
@doc """
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue