hj/pleroma
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ReverseProxy Hackney: Add redirect handling logging

Browse source
This commit is contained in:
Phantasm 2026-02-22 11:20:04 +01:00
commit 95c8b4732f
No known key found for this signature in database
GPG key ID: 2669E588BCC634C8
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/pleroma/reverse_proxy/client/hackney.ex
View file

@ -6,6 +6,8 @@ defmodule Pleroma.ReverseProxy.Client.Hackney do
@behaviour Pleroma.ReverseProxy.Client @behaviour Pleroma.ReverseProxy.Client
@redirect_limit 5 @redirect_limit 5
require Logger
# In-app redirect handler to avoid Hackney redirect bugs: # In-app redirect handler to avoid Hackney redirect bugs:
# - https://github.com/benoitc/hackney/issues/527 (relative/protocol-less redirects can crash Hackney) # - https://github.com/benoitc/hackney/issues/527 (relative/protocol-less redirects can crash Hackney)
# - https://github.com/benoitc/hackney/issues/273 (redirects not followed when using HTTP proxy) # - https://github.com/benoitc/hackney/issues/273 (redirects not followed when using HTTP proxy)
@ -65,11 +67,17 @@ defmodule Pleroma.ReverseProxy.Client.Hackney do
defp redirect(url, resp_headers, env, limit) when limit == 0 do defp redirect(url, resp_headers, env, limit) when limit == 0 do
new_url = absolute_redirect_url(url, resp_headers) new_url = absolute_redirect_url(url, resp_headers)
Logger.debug(
"#{__MODULE__}: Handling redirect #{url} -> #{new_url}; redirect limit was reached - returning response after final redirect"
)
:hackney.request(env.method, new_url, env.headers, env.body, env.req_opts) :hackney.request(env.method, new_url, env.headers, env.body, env.req_opts)
end end
defp redirect(url, resp_headers, env, limit) do defp redirect(url, resp_headers, env, limit) do
new_url = absolute_redirect_url(url, resp_headers) new_url = absolute_redirect_url(url, resp_headers)
Logger.debug("#{__MODULE__}: handling redirect #{url} -> #{new_url}; limit = #{limit}")
res = :hackney.request(env.method, new_url, env.headers, env.body, env.req_opts) res = :hackney.request(env.method, new_url, env.headers, env.body, env.req_opts)
case res do case res do