hj/pleroma
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Auto-expire Create activities only

Browse source
This commit is contained in:
Egor Kislitsyn 2020-02-20 22:04:02 +04:00
commit 819cd46717
No known key found for this signature in database
GPG key ID: 1B49CB15B71E7805
4 changed files with 76 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

35
test/web/activity_pub/mrf/activity_expiration_policy_test.exs
View file

@ -9,7 +9,8 @@ defmodule Pleroma.Web.ActivityPub.MRF.ActivityExpirationPolicyTest do
@id Pleroma.Web.Endpoint.url() <> "/activities/cofe"
test "adds `expires_at` property" do
assert {:ok, %{"expires_at" => expires_at}} = ActivityExpirationPolicy.filter(%{"id" => @id})
assert {:ok, %{"type" => "Create", "expires_at" => expires_at}} =
ActivityExpirationPolicy.filter(%{"id" => @id, "type" => "Create"})
assert Timex.diff(expires_at, NaiveDateTime.utc_now(), :days) == 364
end
@ -17,21 +18,43 @@ defmodule Pleroma.Web.ActivityPub.MRF.ActivityExpirationPolicyTest do
test "keeps existing `expires_at` if it less than the config setting" do
expires_at = NaiveDateTime.utc_now() |> Timex.shift(days: 1)
assert {:ok, %{"expires_at" => ^expires_at}} =
ActivityExpirationPolicy.filter(%{"id" => @id, "expires_at" => expires_at})
assert {:ok, %{"type" => "Create", "expires_at" => ^expires_at}} =
ActivityExpirationPolicy.filter(%{
"id" => @id,
"type" => "Create",
"expires_at" => expires_at
})
end
test "overwrites existing `expires_at` if it greater than the config setting" do
too_distant_future = NaiveDateTime.utc_now() |> Timex.shift(years: 2)
assert {:ok, %{"expires_at" => expires_at}} =
ActivityExpirationPolicy.filter(%{"id" => @id, "expires_at" => too_distant_future})
assert {:ok, %{"type" => "Create", "expires_at" => expires_at}} =
ActivityExpirationPolicy.filter(%{
"id" => @id,
"type" => "Create",
"expires_at" => too_distant_future
})
assert Timex.diff(expires_at, NaiveDateTime.utc_now(), :days) == 364
end
test "ignores remote activities" do
assert {:ok, activity} = ActivityExpirationPolicy.filter(%{"id" => "https://example.com/123"})
assert {:ok, activity} =
ActivityExpirationPolicy.filter(%{
"id" => "https://example.com/123",
"type" => "Create"
})
refute Map.has_key?(activity, "expires_at")
end
test "ignores non-Create activities" do
assert {:ok, activity} =
ActivityExpirationPolicy.filter(%{
"id" => "https://example.com/123",
"type" => "Follow"
})
refute Map.has_key?(activity, "expires_at")
end