PleromaAPI: Change EmojiReact to invisible post response from 400 to 404

lib/pleroma/web/api_spec/operations/emoji_reaction_operation.ex

@@ -7,6 +7,7 @@ defmodule Pleroma.Web.ApiSpec.EmojiReactionOperation do
   alias OpenApiSpex.Schema
   alias Pleroma.Web.ApiSpec.Schemas.Account
   alias Pleroma.Web.ApiSpec.Schemas.ApiError
+  alias Pleroma.Web.ApiSpec.Schemas.ApiNotFoundError
   alias Pleroma.Web.ApiSpec.Schemas.FlakeID
   alias Pleroma.Web.ApiSpec.Schemas.Status
 
@@ -36,7 +37,7 @@ defmodule Pleroma.Web.ApiSpec.EmojiReactionOperation do
       operationId: "EmojiReactionController.index",
       responses: %{
         200 => array_of_reactions_response(),
-        403 => Operation.response("Access denied", "application/json", ApiError)
+        404 => Operation.response("Access denied", "application/json", ApiError)
       }
     }
   end
@@ -55,7 +56,8 @@ defmodule Pleroma.Web.ApiSpec.EmojiReactionOperation do
       operationId: "EmojiReactionController.create",
       responses: %{
         200 => Operation.response("Status", "application/json", Status),
-        400 => Operation.response("Bad Request", "application/json", ApiError)
+        400 => Operation.response("Bad Request", "application/json", ApiError),
+        404 => Operation.response("Not Found", "application/json", ApiNotFoundError)
       }
     }
   end

lib/pleroma/web/api_spec/schemas/api_not_found_error.ex

@@ -0,0 +1,19 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Web.ApiSpec.Schemas.ApiNotFoundError do
+  alias OpenApiSpex.Schema
+
+  require OpenApiSpex
+
+  OpenApiSpex.schema(%{
+    title: "Not Found",
+    description: "Response schema for 404 API errors",
+    type: :object,
+    properties: %{error: %Schema{type: :string}},
+    example: %{
+      "error" => "Record not found"
+    }
+  })
+end

lib/pleroma/web/common_api.ex

@@ -322,7 +322,7 @@ defmodule Pleroma.Web.CommonAPI do
       {:ok, activity}
     else
       {:visible, _} ->
-        {:error, dgettext("errors", "Must be able to access post to interact with it")}
+        {:error, :not_found}
 
       _ ->
         {:error, dgettext("errors", "Could not add reaction emoji")}

lib/pleroma/web/pleroma_api/controllers/emoji_reaction_controller.ex

@@ -39,7 +39,7 @@ defmodule Pleroma.Web.PleromaAPI.EmojiReactionController do
 
       render(conn, "index.json", emoji_reactions: reactions, user: user)
     else
-      {:visible, _} -> {:error, :forbidden}
+      {:visible, _} -> {:error, :not_found}
       _e -> json(conn, [])
     end
   end