Add internal (not managable from API) webhooks

Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>

lib/pleroma/web/admin_api/controllers/fallback_controller.ex

@@ -11,6 +11,12 @@ defmodule Pleroma.Web.AdminAPI.FallbackController do
     |> json(%{error: dgettext("errors", "Not found")})
   end
 
+  def call(conn, {:error, :forbidden}) do
+    conn
+    |> put_status(:forbidden)
+    |> json(%{error: dgettext("errors", "Forbidden")})
+  end
+
   def call(conn, {:error, reason}) do
     conn
     |> put_status(:bad_request)

lib/pleroma/web/admin_api/controllers/webhook_controller.ex

@@ -46,42 +46,49 @@ defmodule Pleroma.Web.AdminAPI.WebhookController do
   end
 
   def update(%{body_params: params} = conn, %{id: id}) do
-    with %Webhook{} = webhook <- Webhook.get(id),
+    with %Webhook{internal: false} = webhook <- Webhook.get(id),
          webhook <- Webhook.update(webhook, params) do
       render(conn, "show.json", webhook: webhook)
+    else
+      %Webhook{internal: true} -> {:error, :forbidden}
     end
   end
 
   def delete(conn, %{id: id}) do
-    with %Webhook{} = webhook <- Webhook.get(id),
+    with %Webhook{internal: false} = webhook <- Webhook.get(id),
          {:ok, webhook} <- Webhook.delete(webhook) do
       render(conn, "show.json", webhook: webhook)
+    else
+      %Webhook{internal: true} -> {:error, :forbidden}
     end
   end
 
   def enable(conn, %{id: id}) do
-    with %Webhook{} = webhook <- Webhook.get(id),
+    with %Webhook{internal: false} = webhook <- Webhook.get(id),
          {:ok, webhook} <- Webhook.set_enabled(webhook, true) do
       render(conn, "show.json", webhook: webhook)
     else
+      %Webhook{internal: true} -> {:error, :forbidden}
       nil -> {:error, :not_found}
     end
   end
 
   def disable(conn, %{id: id}) do
-    with %Webhook{} = webhook <- Webhook.get(id),
+    with %Webhook{internal: false} = webhook <- Webhook.get(id),
          {:ok, webhook} <- Webhook.set_enabled(webhook, false) do
       render(conn, "show.json", webhook: webhook)
     else
+      %Webhook{internal: true} -> {:error, :forbidden}
       nil -> {:error, :not_found}
     end
   end
 
   def rotate_secret(conn, %{id: id}) do
-    with %Webhook{} = webhook <- Webhook.get(id),
+    with %Webhook{internal: false} = webhook <- Webhook.get(id),
          {:ok, webhook} <- Webhook.rotate_secret(webhook) do
       render(conn, "show.json", webhook: webhook)
     else
+      %Webhook{internal: true} -> {:error, :forbidden}
       nil -> {:error, :not_found}
     end
   end

lib/pleroma/web/admin_api/views/webhook_view.ex

@@ -18,6 +18,7 @@ defmodule Pleroma.Web.AdminAPI.WebhookView do
       events: webhook.events,
       secret: webhook.secret,
       enabled: webhook.enabled,
+      internal: webhook.internal,
       created_at: Utils.to_masto_date(webhook.inserted_at),
       updated_at: Utils.to_masto_date(webhook.updated_at)
     }