From 627c944fecebe3d48a6bc35ed62273fc058814ff Mon Sep 17 00:00:00 2001
From: Mark Felder <feld@feld.me>
Date: Wed, 26 Jun 2024 09:20:46 -0400
Subject: [PATCH] Search Indexing: filter indexable activities before inserting
 Oban jobs

---
 lib/pleroma/search.ex | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/lib/pleroma/search.ex b/lib/pleroma/search.ex
index fd0218cb8..b60ca3d05 100644
--- a/lib/pleroma/search.ex
+++ b/lib/pleroma/search.ex
@@ -1,12 +1,26 @@
 defmodule Pleroma.Search do
+  alias Pleroma.Activity
+  alias Pleroma.Object
   alias Pleroma.Workers.SearchIndexingWorker
 
-  def add_to_index(%Pleroma.Activity{id: activity_id}) do
-    SearchIndexingWorker.enqueue("add_to_index", %{"activity" => activity_id})
+  @spec add_to_index(Activity.t()) :: :ok | :error
+  def add_to_index(%Pleroma.Activity{id: activity_id} = activity) do
+    with true <- indexable?(activity),
+         {:ok, %Oban.Job{}} <-
+           SearchIndexingWorker.enqueue("add_to_index", %{"activity" => activity_id}) do
+      :ok
+    else
+      false -> :ok
+      _ -> :error
+    end
   end
 
+  @spec remove_from_index(Object.t()) :: :ok | :error
   def remove_from_index(%Pleroma.Object{id: object_id}) do
-    SearchIndexingWorker.enqueue("remove_from_index", %{"object" => object_id})
+    case SearchIndexingWorker.enqueue("remove_from_index", %{"object" => object_id}) do
+      {:ok, %Oban.Job{}} -> :ok
+      _ -> :error
+    end
   end
 
   def search(query, options) do
@@ -18,4 +32,7 @@ defmodule Pleroma.Search do
     search_module = Pleroma.Config.get([Pleroma.Search, :module])
     search_module.healthcheck_endpoints
   end
+
+  defp indexable?(%Activity{object: %Object{}, data: %{"type" => "Create"}}), do: true
+  defp indexable?(_), do: false
 end