hj/pleroma
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

make bulk user creation from admin works as a transaction

Browse source
This commit is contained in:
Sachin Joshi 2019-06-01 11:17:53 +05:45
commit 5534d4c676
4 changed files with 104 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

66
test/web/admin_api/admin_api_controller_test.exs
View file

@ -36,18 +36,31 @@ defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do
"nickname" => "lain",
"email" => "lain@example.org",
"password" => "test"
},
%{
"nickname" => "lain2",
"email" => "lain2@example.org",
"password" => "test"
}
]
})
assert json_response(conn, 200) == [
%{
"code" => 201,
"code" => 200,
"data" => %{
"email" => "lain@example.org",
"nickname" => "lain"
},
"type" => "success"
},
%{
"code" => 200,
"data" => %{
"email" => "lain2@example.org",
"nickname" => "lain2"
},
"type" => "success"
}
]
end
@ -70,7 +83,7 @@ defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do
]
})
assert json_response(conn, 200) == [
assert json_response(conn, 409) == [
%{
"code" => 409,
"data" => %{
@ -101,7 +114,7 @@ defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do
]
})
assert json_response(conn, 200) == [
assert json_response(conn, 409) == [
%{
"code" => 409,
"data" => %{
@ -113,6 +126,53 @@ defmodule Pleroma.Web.AdminAPI.AdminAPIControllerTest do
}
]
end
test "Multiple user creation works in transaction" do
admin = insert(:user, info: %{is_admin: true})
user = insert(:user)
conn =
build_conn()
|> assign(:user, admin)
|> put_req_header("accept", "application/json")
|> post("/api/pleroma/admin/users", %{
"users" => [
%{
"nickname" => "newuser",
"email" => "newuser@pleroma.social",
"password" => "test"
},
%{
"nickname" => "lain",
"email" => user.email,
"password" => "test"
}
]
})
assert json_response(conn, 409) == [
%{
"code" => 409,
"data" => %{
"email" => user.email,
"nickname" => "lain"
},
"error" => "email has already been taken",
"type" => "error"
},
%{
"code" => 409,
"data" => %{
"email" => "newuser@pleroma.social",
"nickname" => "newuser"
},
"error" => "",
"type" => "error"
}
]
assert User.get_by_nickname("newuser") === nil
end
end
describe "/api/pleroma/admin/users/:nickname" do