hj/pleroma
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Transmogrifier: Fix follow handling when the actor is an object.

Browse source
This commit is contained in:
lain 2019-08-26 14:34:52 -05:00
commit 3da65292b3
7 changed files with 88 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/pleroma/object.ex
View file

@ -230,4 +230,8 @@ defmodule Pleroma.Object do
_ -> :noop
end
end
def get_ap_id(%{"id" => id}), do: id
def get_ap_id(id) when is_binary(id), do: id
def get_ap_id(_), do: {:error, "Object is not a string and has no id."}
end

4
lib/pleroma/web/activity_pub/transmogrifier.ex
View file

@ -464,8 +464,8 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
%{"type" => "Follow", "object" => followed, "actor" => follower, "id" => id} = data,
_options
) do
with %User{local: true} = followed <- User.get_cached_by_ap_id(followed),
{:ok, %User{} = follower} <- User.get_or_fetch_by_ap_id(follower),
with %User{local: true} = followed <- User.get_cached_by_ap_id(Object.get_ap_id(followed)),
{:ok, %User{} = follower} <- User.get_or_fetch_by_ap_id(Object.get_ap_id(follower)),
{:ok, activity} <- ActivityPub.follow(follower, followed, id, false) do
with deny_follow_blocked <- Pleroma.Config.get([:user, :deny_follow_blocked]),
{_, false} <- {:user_blocked, User.blocks?(followed, follower) && deny_follow_blocked},