hj/pleroma
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Pleroma.Web.MastodonAPI.DomainBlockController: dialyzer errors

Browse source 
lib/pleroma/web/mastodon_api/controllers/domain_block_controller.ex:32:call
The function call will not succeed.

Phoenix.Controller.json(
  _conn :: %{
    :assigns => %{:user => _, _ => _},
    :body_params => %{:domain => _, _ => _},
    _ => _
  },
  %{}
)

breaks the contract
(Plug.Conn.t(), term()) :: Plug.Conn.t()

________________________________________________________________________________
lib/pleroma/web/mastodon_api/controllers/domain_block_controller.ex:43:call
The function call will not succeed.

Phoenix.Controller.json(
  _conn :: %{
    :assigns => %{:user => _, _ => _},
    :body_params => %{:domain => _, _ => _},
    _ => _
  },
  %{}
)

breaks the contract
(Plug.Conn.t(), term()) :: Plug.Conn.t()
This commit is contained in:
Mark Felder 2024-01-29 17:44:54 -05:00
commit 378edeaf15
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/pleroma/web/api_spec/operations/domain_block_operation.ex
View file

@ -73,10 +73,10 @@ defmodule Pleroma.Web.ApiSpec.DomainBlockOperation do
%Schema{
type: :object,
properties: %{
domain: %Schema{type: :string}
"domain" => %Schema{type: :string}
}
},
required: false,
required: true,
example: %{
"domain" => "facebook.com"
}

4
lib/pleroma/web/mastodon_api/controllers/domain_block_controller.ex
View file

@ -27,7 +27,7 @@ defmodule Pleroma.Web.MastodonAPI.DomainBlockController do
end
@doc "POST /api/v1/domain_blocks"
def create(%{assigns: %{user: blocker}, body_params: %{domain: domain}} = conn, _params) do
def create(%{assigns: %{user: blocker}, body_params: %{"domain" => domain}} = conn, _params) do
User.block_domain(blocker, domain)
json(conn, %{})
end
@ -38,7 +38,7 @@ defmodule Pleroma.Web.MastodonAPI.DomainBlockController do
end
@doc "DELETE /api/v1/domain_blocks"
def delete(%{assigns: %{user: blocker}, body_params: %{domain: domain}} = conn, _params) do
def delete(%{assigns: %{user: blocker}, body_params: %{"domain" => domain}} = conn, _params) do
User.unblock_domain(blocker, domain)
json(conn, %{})
end