fix(config): keep search startup settings static

test/fixtures/config/static_search.secret.exs

@@ -0,0 +1,5 @@
+import Config
+
+config :pleroma, Pleroma.Search, module: Pleroma.Search.ParadeDB
+config :pleroma, Pleroma.Search.ParadeDB, url: "postgres://localhost/paradedb"
+config :pleroma, Pleroma.Search.ParadeDB.Repo, pool_size: 2

test/mix/tasks/pleroma/config_test.exs

@@ -87,6 +87,14 @@ defmodule Mix.Tasks.Pleroma.ConfigTest do
       config = ConfigDB.get_by_params(%{group: ":pleroma", key: ":first_setting"})
       assert config.value == [key: "value", key2: [Repo]]
     end
+
+    test "static search settings remain in the config file" do
+      MixTask.migrate_to_db("test/fixtures/config/static_search.secret.exs")
+
+      refute ConfigDB.get_by_group_and_key(:pleroma, Pleroma.Search)
+      refute ConfigDB.get_by_group_and_key(:pleroma, Pleroma.Search.ParadeDB)
+      refute ConfigDB.get_by_group_and_key(:pleroma, Pleroma.Search.ParadeDB.Repo)
+    end
   end
 
   describe "with deletion of temp file" do

test/pleroma/config/transfer_task_test.exs

@@ -71,6 +71,31 @@ defmodule Pleroma.Config.TransferTaskTest do
     assert assets_env[:mascots] == [a: 1, b: 2]
   end
 
+  test "does not transfer static search configuration" do
+    search_config = Application.get_env(:pleroma, Pleroma.Search)
+    parade_config = Application.get_env(:pleroma, Pleroma.Search.ParadeDB)
+
+    clear_config(:database_config_blacklist, [])
+
+    insert(:config, key: Pleroma.Search, value: [module: Pleroma.Search.ParadeDB])
+
+    insert(:config,
+      key: Pleroma.Search.ParadeDB,
+      value: [url: "postgres://localhost/paradedb"]
+    )
+
+    insert(:config,
+      key: Pleroma.Search.ParadeDB.Repo,
+      value: [pool_size: 50]
+    )
+
+    TransferTask.start_link([])
+
+    assert Application.get_env(:pleroma, Pleroma.Search) == search_config
+    assert Application.get_env(:pleroma, Pleroma.Search.ParadeDB) == parade_config
+    assert Application.get_env(:pleroma, Pleroma.Search.ParadeDB.Repo)[:pool_size] == 2
+  end
+
   describe "pleroma restart" do
     setup do
       on_exit(fn ->

test/pleroma/config_db_test.exs

@@ -36,6 +36,20 @@ defmodule Pleroma.ConfigDBTest do
     assert config[:goose][:webhook_url] == "https://gander.com/"
   end
 
+  test "get_all_as_keyword/1 excludes static search configuration" do
+    insert(:config, key: Pleroma.Search, value: [module: Pleroma.Search.ParadeDB])
+    insert(:config, key: Pleroma.Search.ParadeDB, value: [url: "postgres://example/db"])
+    insert(:config, key: Pleroma.Search.ParadeDB.Repo, value: [pool_size: 50])
+    insert(:config, key: :instance, value: [name: "Pleroma"])
+
+    config = ConfigDB.get_all_as_keyword(exclude_static: true)
+
+    refute config[:pleroma][Pleroma.Search]
+    refute config[:pleroma][Pleroma.Search.ParadeDB]
+    refute config[:pleroma][Pleroma.Search.ParadeDB.Repo]
+    assert config[:pleroma][:instance] == [name: "Pleroma"]
+  end
+
   describe "update_or_create/1" do
     test "common" do
       config = insert(:config)

test/pleroma/web/admin_api/controllers/config_controller_test.exs

@@ -121,6 +121,19 @@ defmodule Pleroma.Web.AdminAPI.ConfigControllerTest do
       end)
     end
 
+    test "effective configuration omits static search settings", %{conn: conn} do
+      insert(:config, key: Pleroma.Search, value: [module: Pleroma.Search.ParadeDB])
+      insert(:config, key: Pleroma.Search.ParadeDB, value: [url: "postgres://example/db"])
+
+      %{"configs" => configs} =
+        conn
+        |> get("/api/pleroma/admin/config")
+        |> json_response_and_validate_schema(200)
+
+      refute Enum.any?(configs, &(&1["key"] == "Pleroma.Search"))
+      refute Enum.any?(configs, &(&1["key"] == "Pleroma.Search.ParadeDB"))
+    end
+
     test "subkeys with full update right merge", %{conn: conn} do
       insert(:config,
         key: ":emoji",
@@ -1552,12 +1565,15 @@ defmodule Pleroma.Web.AdminAPI.ConfigControllerTest do
       assert web_endpoint["children"]
     end
 
-    test "all keys from description are whitelisted", %{conn: conn} do
+    test "descriptions exclude blacklisted keys", %{conn: conn} do
       conn = get(conn, "/api/pleroma/admin/config/descriptions")
 
       assert response = json_response_and_validate_schema(conn, 200)
 
-      assert length(response) == length(Pleroma.Docs.JSON.compiled_descriptions())
+      refute Enum.any?(response, &(&1["key"] == "Pleroma.Search"))
+      refute Enum.any?(response, &(&1["key"] == "Pleroma.Search.ParadeDB"))
+
+      assert length(response) == length(Pleroma.Docs.JSON.compiled_descriptions()) - 2
     end
 
     test "filters by database configuration blacklist and whitelist", %{conn: conn} do