fix(config): keep search startup settings static

lib/mix/tasks/pleroma/config.ex

@@ -335,9 +335,12 @@ defmodule Mix.Tasks.Pleroma.Config do
     group
     |> Pleroma.Config.Loader.filter_group(settings)
     |> Enum.each(fn {key, value} ->
-      {:ok, _} = ConfigDB.update_or_create(%{group: group, key: key, value: value})
-
-      shell_info("Settings for key #{key} migrated.")
+      if ConfigDB.static?(group, key) do
+        shell_info("Settings for key #{key} must remain in static configuration; skipping.")
+      else
+        {:ok, _} = ConfigDB.update_or_create(%{group: group, key: key, value: value})
+        shell_info("Settings for key #{key} migrated.")
+      end
     end)
 
     shell_info("Settings for group #{inspect(group)} migrated.")

lib/pleroma/config/transfer_task.ex

@@ -47,6 +47,7 @@ defmodule Pleroma.Config.TransferTask do
 
       settings =
         (Repo.all(ConfigDB) ++ deleted_settings)
+        |> Enum.reject(&ConfigDB.static?/1)
         |> Enum.map(&merge_with_default/1)
 
       started_applications = Application.started_applications()

lib/pleroma/config_db.ex

@@ -23,6 +23,12 @@ defmodule Pleroma.ConfigDB do
     {:pleroma, :mrf_keyword, :replace}
   ]
 
+  @static_config [
+    {:pleroma, Pleroma.Search},
+    {:pleroma, Pleroma.Search.ParadeDB},
+    {:pleroma, Pleroma.Search.ParadeDB.Repo}
+  ]
+
   schema "config" do
     field(:key, Pleroma.EctoType.Config.Atom)
     field(:group, Pleroma.EctoType.Config.Atom)
@@ -32,16 +38,32 @@ defmodule Pleroma.ConfigDB do
     timestamps()
   end
 
-  @spec get_all_as_keyword() :: keyword()
-  def get_all_as_keyword do
+  @spec get_all_as_keyword(keyword()) :: keyword()
+  def get_all_as_keyword(options \\ []) do
     ConfigDB
     |> select([c], {c.group, c.key, c.value})
     |> Repo.all()
+    |> maybe_reject_static(options)
     |> Enum.reduce([], fn {group, key, value}, acc ->
       Keyword.update(acc, group, [{key, value}], &Keyword.merge(&1, [{key, value}]))
     end)
   end
 
+  def static?(%{group: group, key: key}), do: static?(group, key)
+  def static?(_config), do: false
+
+  def static?(group, key) do
+    Enum.any?(@static_config, fn {static_group, static_key} ->
+      group in [static_group, inspect(static_group)] and key in [static_key, inspect(static_key)]
+    end)
+  end
+
+  defp maybe_reject_static(configs, exclude_static: true) do
+    Enum.reject(configs, fn {group, key, _value} -> static?(group, key) end)
+  end
+
+  defp maybe_reject_static(configs, _options), do: configs
+
   @spec get_all_by_group(atom() | String.t()) :: [t()]
   def get_all_by_group(group) do
     from(c in ConfigDB, where: c.group == ^group) |> Repo.all()

lib/pleroma/web/admin_api/controllers/config_controller.ex

@@ -75,6 +75,7 @@ defmodule Pleroma.Web.AdminAPI.ConfigController do
       Pleroma.Docs.JSON.compiled_descriptions()
       |> Enum.filter(&allowed_config?(&1, :whitelist))
       |> Enum.reject(&allowed_config?(&1, :blacklist))
+      |> Enum.reject(&ConfigDB.static?/1)
 
     json(conn, translate_descriptions(descriptions))
   end
@@ -92,7 +93,7 @@ defmodule Pleroma.Web.AdminAPI.ConfigController do
 
   def show(conn, _params) do
     with :ok <- configurable_from_database() do
-      configs = ConfigDB.get_all_as_keyword()
+      configs = ConfigDB.get_all_as_keyword(exclude_static: true)
 
       merged =
         Config.Holder.default_config()
@@ -123,6 +124,7 @@ defmodule Pleroma.Web.AdminAPI.ConfigController do
           end)
         end)
         |> List.flatten()
+        |> Enum.reject(&ConfigDB.static?/1)
 
       render(conn, "index.json", %{
         configs: merged,
@@ -137,6 +139,7 @@ defmodule Pleroma.Web.AdminAPI.ConfigController do
         configs
         |> Enum.filter(&allowed_config?(&1, :whitelist))
         |> Enum.reject(&allowed_config?(&1, :blacklist))
+        |> Enum.reject(&(ConfigDB.static?(&1) and not &1[:delete]))
         |> Enum.map(fn
           %{group: group, key: key, delete: true} = params ->
             ConfigDB.delete(%{group: group, key: key, subkeys: params[:subkeys]})