fix(http): enforce max_body again under Hackney 4

Hackney 4 ignores `with_body` and always returns a fully read binary, so
Tesla.Adapter.Hackney never reaches the clause that honours :max_body and
the option became a no-op. Only the gun path still enforced it, through
Pleroma.HTTP.Adapter.Gun. Pleroma.Web.RelMe relies on nothing else, so it
was fetching remote pages unbounded.

Add a middleware that applies the limit for every adapter: reject when
content-length already announces too much, and reject a body that came
back over the limit. Streaming bodies are left alone -- neither adapter
limits those and the caller owns the lease, so failing here on the header
would strand a connection RichMedia is still expected to release.

On the hackney path this bounds what callers are handed rather than peak
memory, since the adapter has read the body before any middleware runs.
This commit is contained in:
Lain Soykaf 2026-07-26 09:29:36 +04:00
commit 0615025f92
No known key found for this signature in database
5 changed files with 330 additions and 1 deletions

View file

@ -130,5 +130,9 @@ defmodule Pleroma.HTTP do
end
defp default_middleware,
do: [Tesla.Middleware.FollowRedirects, Pleroma.Tesla.Middleware.EncodeUrl]
do: [
Tesla.Middleware.FollowRedirects,
Pleroma.Tesla.Middleware.EncodeUrl,
Pleroma.Tesla.Middleware.MaxBody
]
end

View file

@ -0,0 +1,72 @@
# Pleroma: A lightweight social networking server
# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
# SPDX-License-Identifier: AGPL-3.0-only
defmodule Pleroma.Tesla.Middleware.MaxBody do
@moduledoc """
Enforces the `:max_body` adapter option for every adapter.
`Pleroma.HTTP.Adapter.Gun` applies the limit as it accumulates a `:plain`
body, so an oversized response is abandoned mid-transfer. Hackney cannot:
since 4.0 it ignores `with_body` and always hands back a fully read binary
(`hackney:request/5`), so `Tesla.Adapter.Hackney` never takes the branch that
would honour `:max_body`. Without this middleware the option is silently
unenforced there.
The check therefore bounds what callers are handed, and refuses up front when
`content-length` already announces too much. It cannot bound peak memory on
the hackney path, because the adapter has read the body before any middleware
runs.
Streaming bodies are left alone: neither adapter limits those, and the caller
that owns the stream is the one that has to drain and release it.
"""
@behaviour Tesla.Middleware
@impl Tesla.Middleware
def call(%Tesla.Env{opts: opts} = env, next, _opts) do
case opts[:adapter][:max_body] do
limit when is_integer(limit) and limit >= 0 -> run(env, next, limit)
_ -> Tesla.run(env, next)
end
end
defp run(env, next, limit) do
with {:ok, env} <- Tesla.run(env, next),
:ok <- check(env, limit) do
{:ok, env}
end
end
defp check(%Tesla.Env{body: body} = env, limit) when is_binary(body) do
with :ok <- check_content_length(env, limit) do
check_body(body, limit)
end
end
# body_as: :chunks and response: :stream hand back a client the caller drains
# itself, applying its own limit (Pleroma.Web.RichMedia.Helpers). There is
# nothing to measure, and failing on the header alone would strand the pool
# lease that only the caller holds a handle to.
defp check(_env, _limit), do: :ok
# A bodyless response may still announce the entity's size.
defp check_content_length(%Tesla.Env{method: :head}, _limit), do: :ok
defp check_content_length(%Tesla.Env{status: status}, _limit) when status in [204, 304],
do: :ok
defp check_content_length(env, limit) do
with value when is_binary(value) <- Tesla.get_header(env, "content-length"),
{length, ""} <- Integer.parse(value) do
if length > limit, do: {:error, :body_too_large}, else: :ok
else
_ -> :ok
end
end
defp check_body(body, limit) do
if byte_size(body) > limit, do: {:error, :body_too_large}, else: :ok
end
end