From 1229bd2f486ca9fb97336baa6fcbdf2f8e949894 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Sat, 18 Jan 2025 19:15:26 +0200 Subject: [PATCH 1/7] use auto-fill instead of fixed column count --- src/App.scss | 2 -- .../status_action_buttons/status_action_buttons.scss | 2 +- src/components/user_card/user_card.scss | 4 ---- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/App.scss b/src/App.scss index 081ce2fdb..1b781304e 100644 --- a/src/App.scss +++ b/src/App.scss @@ -339,8 +339,6 @@ nav { grid-template-areas: "content"; padding: 0; - --_actionsColumnCount: 3; - .column { padding-top: 0; margin: var(--navbar-height) 0 0 0; diff --git a/src/components/status_action_buttons/status_action_buttons.scss b/src/components/status_action_buttons/status_action_buttons.scss index e18083513..89f9ade82 100644 --- a/src/components/status_action_buttons/status_action_buttons.scss +++ b/src/components/status_action_buttons/status_action_buttons.scss @@ -3,7 +3,7 @@ .StatusActionButtons { .quick-action-buttons { display: grid; - grid-template-columns: repeat(var(--_actionsColumnCount, 6), 1fr); + grid-template-columns: repeat(auto-fill, 6em); grid-auto-flow: row dense; grid-auto-rows: 1fr; grid-gap: 1.25em 1em; diff --git a/src/components/user_card/user_card.scss b/src/components/user_card/user_card.scss index 13ef610c6..843f46e4c 100644 --- a/src/components/user_card/user_card.scss +++ b/src/components/user_card/user_card.scss @@ -292,10 +292,6 @@ } } -#sidebar { - --_actionsColumnCount: 4; -} - .sidebar .edit-profile-button { display: none; } From ee8008ef93319237ccc210b4f5c20c627a66b81f Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Sat, 18 Jan 2025 19:31:20 +0200 Subject: [PATCH 2/7] fix external link not working --- src/components/status_action_buttons/action_button.js | 3 ++- src/components/status_action_buttons/action_button.vue | 5 +++-- .../status_action_buttons/action_button_container.vue | 1 - 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/components/status_action_buttons/action_button.js b/src/components/status_action_buttons/action_button.js index b87e07687..193a96ee9 100644 --- a/src/components/status_action_buttons/action_button.js +++ b/src/components/status_action_buttons/action_button.js @@ -112,11 +112,12 @@ export default { this.$store.dispatch('reactWithEmoji', { id: this.status.id, emoji }) } }, - doActionWrap (button) { + doActionWrap (button, close) { if (button.name === 'emoji') { this.$refs.picker.showPicker() } else { this.getComponent(button) === 'button' && this.doAction(button) + close() } } } diff --git a/src/components/status_action_buttons/action_button.vue b/src/components/status_action_buttons/action_button.vue index 40d3397c5..b9dca8818 100644 --- a/src/components/status_action_buttons/action_button.vue +++ b/src/components/status_action_buttons/action_button.vue @@ -8,11 +8,12 @@ class="action-button-inner" :class="buttonInnerClass" role="menuitem" + type="button" + target="_blank" :tabindex="0" :disabled="buttonClass.disabled" :href="getComponent(button) == 'a' ? button.link?.(funcArg) || getRemoteInteractionLink : undefined" - @click.prevent="doActionWrap(button)" - @click="button.name === 'emoji' ? () => {} : close()" + @click="doActionWrap(button, close)" > -