From d94cac637610e404d1b111d8e248925284a7da3d Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 10 Jun 2026 19:30:08 +0300 Subject: [PATCH] review pass 1 --- src/App.scss | 24 ++-- src/components/block_card/block_card.vue | 4 +- src/components/interactions/interactions.js | 2 +- src/components/list/list.vue | 1 + src/components/lists_edit/lists_edit.vue | 2 +- .../moderation_tools/moderation_tools.js | 33 +++--- .../mrf_transparency_panel.vue | 12 +- .../admin_tabs/admin_status_card.js | 95 ---------------- .../admin_tabs/admin_status_card.vue | 106 ------------------ .../{admin_card.js => admin_user_card.js} | 7 +- .../{admin_card.scss => admin_user_card.scss} | 2 +- .../{admin_card.vue => admin_user_card.vue} | 6 +- .../admin_tabs/frontends_tab.js | 2 +- .../settings_modal/admin_tabs/links_tab.js | 6 +- .../settings_modal/admin_tabs/users_tab.js | 14 +-- .../settings_modal/admin_tabs/users_tab.vue | 2 +- .../settings_modal/helpers/setting.js | 4 +- .../settings_modal/settings_modal.js | 4 +- .../settings_modal_admin_content.vue | 3 +- .../settings_modal_user_content.vue | 2 +- .../tabs/mutes_and_blocks_tab.js | 9 -- .../tabs/mutes_and_blocks_tab.vue | 2 +- src/components/user_profile/user_profile.js | 1 + .../user_profile/user_profile_admin_view.js | 2 +- src/i18n/en.json | 3 - 25 files changed, 56 insertions(+), 292 deletions(-) delete mode 100644 src/components/settings_modal/admin_tabs/admin_status_card.js delete mode 100644 src/components/settings_modal/admin_tabs/admin_status_card.vue rename src/components/settings_modal/admin_tabs/{admin_card.js => admin_user_card.js} (82%) rename src/components/settings_modal/admin_tabs/{admin_card.scss => admin_user_card.scss} (86%) rename src/components/settings_modal/admin_tabs/{admin_card.vue => admin_user_card.vue} (95%) diff --git a/src/App.scss b/src/App.scss index 3e1e7e2f2..9618a2ac4 100644 --- a/src/App.scss +++ b/src/App.scss @@ -411,6 +411,14 @@ nav { button:not(.button-default) { color: var(--text); font-size: 100%; + text-align: initial; + padding: 0; + background: none; + border: none; + outline: none; + display: inline; + font-family: inherit; + line-height: unset; } &.disabled { @@ -436,22 +444,6 @@ nav { --__line-height: 1.5em; --__horizontal-gap: 0.75em; --__vertical-gap: 0.5em; - - &.-non-interactive { - cursor: auto; - } - - > a, - > button:not(.button-default) { - text-align: initial; - padding: 0; - background: none; - border: none; - outline: none; - display: inline; - font-family: inherit; - line-height: unset; - } } .button-unstyled { diff --git a/src/components/block_card/block_card.vue b/src/components/block_card/block_card.vue index 90b9a2b16..be6069c14 100644 --- a/src/components/block_card/block_card.vue +++ b/src/components/block_card/block_card.vue @@ -1,5 +1,5 @@ diff --git a/src/components/interactions/interactions.js b/src/components/interactions/interactions.js index 5dc2a8714..d008c4b30 100644 --- a/src/components/interactions/interactions.js +++ b/src/components/interactions/interactions.js @@ -17,7 +17,7 @@ const Interactions = { allowFollowingMove: this.$store.state.users.currentUser.allow_following_move, filterMode: tabModeDict.mentions, - canSeeReports: this.$store.state.users.currentUser.has.has( + canSeeReports: this.$store.state.users.currentUser.privileges.has( 'reports_manage_reports', ), } diff --git a/src/components/list/list.vue b/src/components/list/list.vue index 317eb293f..c3e041201 100644 --- a/src/components/list/list.vue +++ b/src/components/list/list.vue @@ -1,6 +1,7 @@ - + - + diff --git a/src/components/settings_modal/admin_tabs/frontends_tab.js b/src/components/settings_modal/admin_tabs/frontends_tab.js index ea7b970fb..9bec3d763 100644 --- a/src/components/settings_modal/admin_tabs/frontends_tab.js +++ b/src/components/settings_modal/admin_tabs/frontends_tab.js @@ -105,7 +105,7 @@ const FrontendsTab = { const ref = suggestRef || this.getSuggestedRef(frontend) const { name } = frontend - useAdminSettingsStore.updateAdminDraft({ + useAdminSettingsStore().updateAdminDraft({ path: [':pleroma', ':frontends', ':primary'], value: { name, ref }, }) diff --git a/src/components/settings_modal/admin_tabs/links_tab.js b/src/components/settings_modal/admin_tabs/links_tab.js index b4563576b..a6b99483b 100644 --- a/src/components/settings_modal/admin_tabs/links_tab.js +++ b/src/components/settings_modal/admin_tabs/links_tab.js @@ -112,19 +112,19 @@ const LinksTab = { }, methods: { checkRel(e) { - useAdminSettingsStore.updateAdminDraft({ + useAdminSettingsStore().updateAdminDraft({ path: [':pleroma', 'Pleroma.Formatter', ':rel'], value: e ? '' : false, }) }, checkClass(e) { - useAdminSettingsStore.updateAdminDraft({ + useAdminSettingsStore().updateAdminDraft({ path: [':pleroma', 'Pleroma.Formatter', ':class'], value: e ? '' : false, }) }, checkTruncate(e) { - useAdminSettingsStore.updateAdminDraft({ + useAdminSettingsStore().updateAdminDraft({ path: [':pleroma', 'Pleroma.Formatter', ':truncate'], value: e ? 20 : false, }) diff --git a/src/components/settings_modal/admin_tabs/users_tab.js b/src/components/settings_modal/admin_tabs/users_tab.js index c12111263..640afa507 100644 --- a/src/components/settings_modal/admin_tabs/users_tab.js +++ b/src/components/settings_modal/admin_tabs/users_tab.js @@ -5,10 +5,8 @@ import Checkbox from 'src/components/checkbox/checkbox.vue' import GenericConfirm from 'src/components/confirm_modal/generic_confirm.vue' import List from 'src/components/list/list.vue' import ModerationTools from 'src/components/moderation_tools/moderation_tools.vue' -import ProgressButton from 'src/components/progress_button/progress_button.vue' import Select from 'src/components/select/select.vue' -import AdminCard from 'src/components/settings_modal/admin_tabs/admin_card.vue' -import TabSwitcher from 'src/components/tab_switcher/tab_switcher.jsx' +import AdminUserCard from 'src/components/settings_modal/admin_tabs/admin_user_card.vue' import { useAdminSettingsStore } from 'src/stores/admin_settings.js' @@ -18,18 +16,10 @@ const UsersTab = { Select, BasicUserCard, List, - ProgressButton, - AdminCard, - TabSwitcher, + AdminUserCard, ModerationTools, GenericConfirm, }, - provide() { - return { - defaultDraftMode: true, - defaultSource: 'admin', - } - }, data() { return { filtersOrigin: 'local', diff --git a/src/components/settings_modal/admin_tabs/users_tab.vue b/src/components/settings_modal/admin_tabs/users_tab.vue index 1dbd7bcb0..a12c76ddd 100644 --- a/src/components/settings_modal/admin_tabs/users_tab.vue +++ b/src/components/settings_modal/admin_tabs/users_tab.vue @@ -131,7 +131,7 @@