From 2ad5c3d3fe097e2db9aff764124f51dbb728185a Mon Sep 17 00:00:00 2001 From: tusooa Date: Tue, 7 Jan 2025 20:31:07 -0500 Subject: [PATCH] Do not check npm version This project does not make use of npm at all. In addition, corepack's npm will refuse to run in a project that defines packageManager in package.json to be yarn. If we are using standalone yarn legacy, it will just run fine. If using corepack, it will automatically download (if needed) and use yarn v1. --- build/check-versions.js | 5 ----- changelog.d/no-check-npm.skip | 0 package.json | 7 +++---- 3 files changed, 3 insertions(+), 9 deletions(-) create mode 100644 changelog.d/no-check-npm.skip diff --git a/build/check-versions.js b/build/check-versions.js index e2b6cf74c..a269a5bc3 100644 --- a/build/check-versions.js +++ b/build/check-versions.js @@ -11,11 +11,6 @@ var versionRequirements = [ name: 'node', currentVersion: semver.clean(process.version), versionRequirement: packageConfig.engines.node - }, - { - name: 'npm', - currentVersion: exec('npm --version'), - versionRequirement: packageConfig.engines.npm } ] diff --git a/changelog.d/no-check-npm.skip b/changelog.d/no-check-npm.skip new file mode 100644 index 000000000..e69de29bb diff --git a/package.json b/package.json index 182a541d9..b3c44aa2a 100644 --- a/package.json +++ b/package.json @@ -10,8 +10,8 @@ "unit": "karma start test/unit/karma.conf.js --single-run", "unit:watch": "karma start test/unit/karma.conf.js --single-run=false", "e2e": "node test/e2e/runner.js", - "test": "npm run unit && npm run e2e", - "stylelint": "npx stylelint '**/*.scss' '**/*.vue'", + "test": "yarn run unit && yarn run e2e", + "stylelint": "yarn exec stylelint '**/*.scss' '**/*.vue'", "lint": "eslint --ext .js,.vue src test/unit/specs test/e2e/specs", "lint-fix": "eslint --fix --ext .js,.vue src test/unit/specs test/e2e/specs" }, @@ -131,8 +131,7 @@ "webpack-merge": "0.20.0" }, "engines": { - "node": ">= 16.0.0", - "npm": ">= 3.0.0" + "node": ">= 16.0.0" }, "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" }