fixes

src/api/helpers.js

@@ -37,11 +37,7 @@ export const paramsString = (params = {}) => {
 
   arrays.forEach(([k, array]) => {
     array.forEach((v) => {
-      if (
+      if (typeof v === 'object' || typeof v === 'function' || v === undefined)
-        typeof v === 'object' ||
-        typeof v === 'function' ||
-        v === undefined
-      )
         throw new TypeError('Array param cannot contain non-primitives!')
     })
   })

src/components/conversation/conversation.js

@@ -305,11 +305,10 @@ const conversation = {
     topLevel() {
       const topLevel = this.conversation.reduce(
         (tl, cur) =>
-          tl.filter(
+          tl.filter((k) =>
-            (k) =>
+            this.getReplies(cur.id)
-              this.getReplies(cur.id)
+              .map((v) => v.id)
-                .map((v) => v.id)
+              .includes(k.id),
-                .includes(k.id),
           ),
         this.conversation,
       )

src/components/settings_modal/helpers/unit_setting.js

@@ -67,7 +67,10 @@ export default {
       return this.$t(['settings', 'units', this.unitSet, value].join('.'))
     },
     updateValue(e) {
-      this.configSink(this.path, Number.parseFloat(e.target.value) + this.stateUnit)
+      this.configSink(
+        this.path,
+        Number.parseFloat(e.target.value) + this.stateUnit,
+      )
     },
     updateUnit(e) {
       let value = this.stateValue

src/services/notification_utils/notification_utils.js

@@ -95,8 +95,7 @@ export const filteredNotificationsFromStore = (
   types,
 ) => {
   // map is just to clone the array since sort mutates it and it causes some issues
-  const sortedNotifications = notificationsFromStore(store)
+  const sortedNotifications = notificationsFromStore(store).sort(sortById)
-    .sort(sortById)
   // TODO implement sorting elsewhere and make it optional
   return sortedNotifications.filter((notification) =>
     (types || visibleTypes(notificationVisibility)).includes(notification.type),

src/services/style_setter/style_setter.js

@@ -359,7 +359,9 @@ export const getResourcesIndex = async (url, parser = (x) => x) => {
 
   const total = [...custom, ...builtin]
   if (total.length === 0) {
-    throw new Error(`Resource at ${url} and ${customUrl} completely unavailable. Panicking`)
+    throw new Error(
+      `Resource at ${url} and ${customUrl} completely unavailable. Panicking`,
+    )
   }
   return Object.fromEntries(total)
 }

src/services/sw/sw.js

@@ -28,10 +28,8 @@ function getOrCreateServiceWorker() {
 }
 
 function subscribePush(registration, isEnabled, vapidPublicKey) {
-  if (!isEnabled)
+  if (!isEnabled) throw new Error('Web Push is disabled in config')
-    throw new Error('Web Push is disabled in config')
+  if (!vapidPublicKey) throw new Error('VAPID public key is not found')
-  if (!vapidPublicKey)
-    throw new Error('VAPID public key is not found')
 
   const subscribeOptions = {
     userVisibleOnly: false,

src/services/theme_data/theme_data_3.service.js

@@ -262,7 +262,7 @@ export const init = ({
           ...r,
         })),
       )
-      .flat()
+      .flat(),
     ...inputRuleset,
   ].map((rule) => {
     normalizeCombination(rule)