Merge branch 'disjointed-popovers' into shigusegubu-vue3

* disjointed-popovers:
  fix the incorrect rounding in nav list
  re-unfuck the timeline popover
  Revert "unify styling of timelines dropdown with other dropdown menus"

src/components/nav_panel/nav_panel.vue

@@ -113,7 +113,9 @@
     border-color: $fallback--border;
     border-color: var(--border, $fallback--border);
     padding: 0;
+  }
 
+  > li {
     &:first-child .menu-item {
       border-top-right-radius: $fallback--panelRadius;
       border-top-right-radius: var(--panelRadius, $fallback--panelRadius);

src/components/timeline_menu/timeline_menu.vue

@@ -3,19 +3,17 @@
     trigger="click"
     class="TimelineMenu"
     :class="{ 'open': isOpen }"
-    :margin="{ left: -15, right: -200 }"
     :bound-to="{ x: 'container' }"
-    popover-class="timeline-menu-popover-wrap"
+    bound-to-selector=".Timeline"
+    popover-class="timeline-menu-popover popover-default"
     @show="openMenu"
     @close="() => isOpen = false"
   >
     <template v-slot:content>
-      <div class="timeline-menu-popover popover-default">
       <TimelineMenuContent />
-      </div>
     </template>
     <template v-slot:trigger>
-      <button class="button-unstyled title timeline-menu-title">
+      <span class="button-unstyled title timeline-menu-title">
         <span class="timeline-title">{{ timelineName() }}</span>
         <span>
           <FAIcon
@@ -27,7 +25,7 @@
           class="click-blocker"
           @click="blockOpen"
         />
-      </button>
+      </span>
     </template>
   </Popover>
 </template>
@@ -38,42 +36,18 @@
 @import '../../_variables.scss';
 
 .TimelineMenu {
-  flex-shrink: 1;
   margin-right: auto;
   min-width: 0;
-  width: 24rem;
 
   .popover-trigger-button {
     vertical-align: bottom;
   }
 
-  .timeline-menu-popover-wrap {
-    overflow: hidden;
-    // Match panel heading padding to line up menu with bottom of heading
-    margin-top: 0.6rem;
-    padding: 0 15px 15px 15px;
-  }
-
-  .timeline-menu-popover {
-    width: 24rem;
-    max-width: 100vw;
-    margin: 0;
-    font-size: 1rem;
-    border-top-right-radius: 0;
-    border-top-left-radius: 0;
-    transform: translateY(-100%);
-    transition: transform 100ms;
-  }
-
   .panel::after {
     border-top-right-radius: 0;
     border-top-left-radius: 0;
   }
 
-  &.open .timeline-menu-popover {
-    transform: translateY(0);
-  }
-
   .timeline-menu-title {
     margin: 0;
     cursor: pointer;
@@ -108,6 +82,16 @@
     box-shadow: var(--popoverShadow);
   }
 
+}
+
+.timeline-menu-popover {
+  min-width: 24rem;
+  max-width: 100vw;
+  margin-top: 0.6rem;
+  font-size: 1rem;
+  border-top-right-radius: 0;
+  border-top-left-radius: 0;
+
   ul {
     list-style: none;
     margin: 0;

src/components/timeline_menu/timeline_menu_content.vue

@@ -1,8 +1,8 @@
 <template>
-  <div class="dropdown-menu">
+  <ul>
+    <li v-if="currentUser">
       <router-link
-      v-if="currentUser"
+        class="menu-item"
-      class="dropdown-item button-default"
         :to="{ name: 'friends' }"
       >
         <FAIcon
@@ -11,9 +11,10 @@
           icon="home"
         />{{ $t("nav.home_timeline") }}
       </router-link>
+    </li>
+    <li v-if="currentUser || !privateMode">
       <router-link
-      v-if="currentUser || !privateMode"
+        class="menu-item"
-      class="dropdown-item button-default"
         :to="{ name: 'public-timeline' }"
       >
         <FAIcon
@@ -22,9 +23,10 @@
           icon="users"
         />{{ $t("nav.public_tl") }}
       </router-link>
+    </li>
+    <li v-if="federating && (currentUser || !privateMode)">
       <router-link
-      v-if="federating && (currentUser || !privateMode)"
+        class="menu-item"
-      class="dropdown-item button-default"
         :to="{ name: 'public-external-timeline' }"
       >
         <FAIcon
@@ -33,9 +35,10 @@
           icon="globe"
         />{{ $t("nav.twkn") }}
       </router-link>
+    </li>
+    <li v-if="currentUser">
       <router-link
-      v-if="currentUser"
+        class="menu-item"
-      class="dropdown-item button-default"
         :to="{ name: 'bookmarks'}"
       >
         <FAIcon
@@ -44,9 +47,10 @@
           icon="bookmark"
         />{{ $t("nav.bookmarks") }}
       </router-link>
+    </li>
+    <li v-if="currentUser">
       <router-link
-      v-if="currentUser"
+        class="menu-item"
-      class="dropdown-item button-default"
         :to="{ name: 'dms', params: { username: currentUser.screen_name } }"
       >
         <FAIcon
@@ -55,7 +59,8 @@
           icon="envelope"
         />{{ $t("nav.dms") }}
       </router-link>
-  </div>
+    </li>
+  </ul>
 </template>
 
 <script src="./timeline_menu_content.js" ></script>