From 97c9b6e25d8b544bbb70056762045949661717b0 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Tue, 18 Feb 2025 18:30:08 +0200 Subject: [PATCH] fix and improve tests --- src/services/theme_data/theme_data_3.service.js | 3 ++- test/unit/specs/services/theme_data/theme_data3.spec.js | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/services/theme_data/theme_data_3.service.js b/src/services/theme_data/theme_data_3.service.js index 11d702d3b..b25e13452 100644 --- a/src/services/theme_data/theme_data_3.service.js +++ b/src/services/theme_data/theme_data_3.service.js @@ -154,13 +154,13 @@ componentsContext.keys().forEach(key => { } components[component.name] = component }) + Object.keys(components).forEach(key => { if (key === 'Root') return components.Root.validInnerComponents = components.Root.validInnerComponents || [] components.Root.validInnerComponents.push(key) }) - Object.keys(components).forEach(key => { const component = components[key] const { validInnerComponents = [] } = component @@ -571,6 +571,7 @@ export const init = ({ } if ( + !liteMode && parent?.component !== 'Root' && !virtualComponents.has(component.name) && !transparentComponents.has(component.name) && diff --git a/test/unit/specs/services/theme_data/theme_data3.spec.js b/test/unit/specs/services/theme_data/theme_data3.spec.js index b76ea5969..b4e1906ba 100644 --- a/test/unit/specs/services/theme_data/theme_data3.spec.js +++ b/test/unit/specs/services/theme_data/theme_data3.spec.js @@ -1,4 +1,3 @@ -// import { topoSort } from 'src/services/theme_data/theme_data.service.js' import { getAllPossibleCombinations } from 'src/services/theme_data/iss_utils.js' @@ -120,6 +119,7 @@ describe('Theme Data 3', () => { opacity: 0.5 } }], + onlyNormalState: true, ultimateBackgroundColor: '#DEADAF' }) @@ -142,9 +142,9 @@ describe('Theme Data 3', () => { */ - expect(panelRule).to.have.nested.deep.property('dynamicVars.stacked.r').that.is.closeTo(88.8, 0.01) - expect(panelRule).to.have.nested.deep.property('dynamicVars.stacked.g').that.is.closeTo(133.2, 0.01) - expect(panelRule).to.have.nested.deep.property('dynamicVars.stacked.b').that.is.closeTo(134, 0.01) + expect(panelRule).to.have.nested.deep.property('dynamicVars.stacked.r').that.is.closeTo(111, 0.01) + expect(panelRule).to.have.nested.deep.property('dynamicVars.stacked.g').that.is.closeTo(150.5, 0.01) + expect(panelRule).to.have.nested.deep.property('dynamicVars.stacked.b').that.is.closeTo(151.5, 0.01) }) }) })