lint

src/components/announcement/announcement.js

@@ -29,8 +29,8 @@ const Announcement = {
       currentUser: (state) => state.users.currentUser,
     }),
     canEditAnnouncement() {
-      return (
+      return this.currentUser?.privileges.has(
-        this.currentUser?.privileges.has('announcements_manage_announcements')
+        'announcements_manage_announcements',
       )
     },
     content() {

src/components/announcements_page/announcements_page.js

@@ -33,8 +33,8 @@ const AnnouncementsPage = {
       return useAnnouncementsStore().announcements
     },
     canPostAnnouncement() {
-      return (
+      return this.currentUser?.privileges.has(
-        this.currentUser?.privileges.has('announcements_manage_announcements')
+        'announcements_manage_announcements',
       )
     },
   },

src/components/edit_status_modal/edit_status_modal.js

@@ -42,9 +42,7 @@ const EditStatusModal = {
     },
     isFormVisible(val) {
       if (val) {
-        this.$nextTick(
+        this.$nextTick(() => this.$el?.querySelector('textarea').focus())
-          () => this.$el?.querySelector('textarea').focus(),
-        )
       }
     },
   },

src/components/mention_link/mention_link.js

@@ -75,9 +75,7 @@ const MentionLink = {
   },
   computed: {
     user() {
-      return (
+      return this.url && this.$store?.getters.findUserByUrl(this.url)
-        this.url && this.$store?.getters.findUserByUrl(this.url)
-      )
     },
     isYou() {
       // FIXME why user !== currentUser???

src/components/navigation/filter.js

@@ -15,8 +15,7 @@ export const filterNavigation = (
     if (!isFederating && set.has('federating')) return false
     if (!currentUser && isPrivate && set.has('!private')) return false
     if (!currentUser && !(anon || anonRoute)) return false
-    if ((!currentUser?.locked) && set.has('lockedUser'))
+    if (!currentUser?.locked && set.has('lockedUser')) return false
-      return false
     if (!hasChats && set.has('chats')) return false
     if (!hasAnnouncements && set.has('announcements')) return false
     if (!supportsBubbleTimeline && set.has('supportsBubbleTimeline'))

src/components/poll/poll.js

@@ -39,13 +39,13 @@ export default {
       return storePoll || {}
     },
     options() {
-      return (this.poll?.options) || []
+      return this.poll?.options || []
     },
     expiresAt() {
-      return (this.poll?.expires_at) || null
+      return this.poll?.expires_at || null
     },
     expired() {
-      return (this.poll?.expired) || false
+      return this.poll?.expired || false
     },
     expirationLabel() {
       if (useMergedConfigStore().mergedConfig.useAbsoluteTimeFormat) {

src/components/popover/popover.js

@@ -129,9 +129,7 @@ const Popover = {
       // Popover will be anchored around this element, trigger ref is the container, so
       // its children are what are inside the slot. Expect only one v-slot:trigger.
       const anchorEl =
-        this.anchorEl ||
+        this.anchorEl || this.$refs.trigger?.children[0] || this.$el
-        (this.$refs.trigger?.children[0]) ||
-        this.$el
       // SVGs don't have offsetWidth/Height, use fallback
       const anchorHeight = anchorEl.offsetHeight || anchorEl.clientHeight
       const anchorWidth = anchorEl.offsetWidth || anchorEl.clientWidth
@@ -246,12 +244,12 @@ const Popover = {
         if (bottomBoundary + content.offsetHeight > yBounds.max) usingTop = true
         if (topBoundary - content.offsetHeight < yBounds.min) usingTop = false
 
-        const yOffset = (this.offset?.y) || 0
+        const yOffset = this.offset?.y || 0
         translateY = usingTop
           ? topBoundary - yOffset - content.offsetHeight
           : bottomBoundary + yOffset
 
-        const xOffset = (this.offset?.x) || 0
+        const xOffset = this.offset?.x || 0
         translateX = origin.x + horizOffset + xOffset
       } else {
         // Default to whatever user wished with placement prop
@@ -267,12 +265,12 @@ const Popover = {
         if (rightBoundary + content.offsetWidth > xBounds.max) usingLeft = true
         if (leftBoundary - content.offsetWidth < xBounds.min) usingLeft = false
 
-        const xOffset = (this.offset?.x) || 0
+        const xOffset = this.offset?.x || 0
         translateX = usingLeft
           ? leftBoundary - xOffset - content.offsetWidth
           : rightBoundary + xOffset
 
-        const yOffset = (this.offset?.y) || 0
+        const yOffset = this.offset?.y || 0
         translateY = origin.y + vertOffset + yOffset
       }
 

src/components/post_status_modal/post_status_modal.js

@@ -40,9 +40,7 @@ const PostStatusModal = {
     },
     isFormVisible(val) {
       if (val) {
-        this.$nextTick(
+        this.$nextTick(() => this.$el?.querySelector('textarea').focus())
-          () => this.$el?.querySelector('textarea').focus(),
-        )
       }
     },
   },

src/components/rich_content/rich_content.jsx

@@ -258,10 +258,7 @@ export default {
             currentMentions = null
           }
         } else if (Tag === 'span') {
-          if (
+          if (this.handleLinks && fullAttrs.class?.includes('h-card')) {
-            this.handleLinks &&
-            fullAttrs.class?.includes('h-card')
-          ) {
             return ['', children.map(processItem), '']
           }
         }
@@ -299,7 +296,7 @@ export default {
             const attrs = getAttrs(opener, () => true)
             // should only be this
             if (
-              (fullAttrs.class?.includes('hashtag')) || // Pleroma style
+              fullAttrs.class?.includes('hashtag') || // Pleroma style
               fullAttrs.rel === 'tag' // Mastodon style
             ) {
               return renderHashtag(attrs, children, encounteredTextReverse)

src/components/status/status.js

@@ -128,8 +128,7 @@ const Status = {
   computed: {
     showReasonMutedThread() {
       return (
-        (this.status.thread_muted ||
+        (this.status.thread_muted || this.status.reblog?.thread_muted) &&
-          (this.status.reblog?.thread_muted)) &&
         !this.inConversation
       )
     },

src/components/tab_switcher/tab_switcher.jsx

@@ -111,7 +111,11 @@ export default {
               type="button"
               role="tab"
             >
-              <img src={props.image} alt={props['image-tooltip']} title={props['image-tooltip']} />
+              <img
+                src={props.image}
+                alt={props['image-tooltip']}
+                title={props['image-tooltip']}
+              />
               {props.label ? '' : props.label}
             </button>
           </div>

src/services/chat_utils/chat_utils.js

@@ -12,9 +12,7 @@ export const maybeShowChatNotification = (chat) => {
     body: chat.lastMessage.content,
   }
 
-  if (
+  if (chat.lastMessage.attachment?.type === 'image') {
-    chat.lastMessage.attachment?.type === 'image'
-  ) {
     opts.image = chat.lastMessage.attachment.preview_url
   }
 

src/services/notification_utils/notification_utils.js

@@ -175,10 +175,7 @@ export const prepareNotificationObject = (notification, i18n) => {
   }
 
   // Shows first attached non-nsfw image, if any. Should add configuration for this somehow...
-  if (
+  if (!status.nsfw && status?.attachments?.[0]?.mimetype.startsWith('image/')) {
-    !status.nsfw &&
-    status?.attachments?.[0]?.mimetype.startsWith('image/')
-  ) {
     notifObj.image = status.attachments[0].url
   }
 

src/services/sw/sw.js

@@ -1,7 +1,9 @@
 /* global process */
 function urlBase64ToUint8Array(base64String) {
   const padding = '='.repeat((4 - (base64String.length % 4)) % 4)
-  const base64 = (base64String + padding).replaceAll('-', '+').replace(/_/g, '/')
+  const base64 = (base64String + padding)
+    .replaceAll('-', '+')
+    .replace(/_/g, '/')
 
   const rawData = window.atob(base64)
   return Uint8Array.from([...rawData].map((char) => char.codePointAt(0)))

src/services/theme_data/theme_data.service.js

@@ -244,10 +244,7 @@ export const OPACITIES = Object.entries(SLOT_INHERITANCE).reduce((acc, [k]) => {
       ...acc,
       [opacity]: {
         defaultValue: DEFAULT_OPACITY[opacity] || 1,
-        affectedSlots: [
+        affectedSlots: [...(acc[opacity]?.affectedSlots || []), k],
-          ...((acc[opacity]?.affectedSlots) || []),
-          k,
-        ],
       },
     }
   } else {

src/stores/chats.js

@@ -69,8 +69,7 @@ export const useChatsStore = defineStore('chats', {
 
         if (chat) {
           const isNewMessage =
-            (chat.lastMessage?.id) !==
+            chat.lastMessage?.id !== updatedChat.lastMessage?.id
-            (updatedChat.lastMessage?.id)
           chat.lastMessage = updatedChat.lastMessage
           chat.unread = updatedChat.unread
           chat.updated_at = updatedChat.updated_at

src/stores/interface.js

@@ -577,7 +577,8 @@ export const useInterfaceStore = defineStore('interface', {
             return { name: x.variant, ...cleanDirectives }
           })
           .forEach((palette) => {
-            const key = 'style.' + palette.name.toLowerCase().replaceAll(' ', '_')
+            const key =
+              'style.' + palette.name.toLowerCase().replaceAll(' ', '_')
             if (!firstStylePaletteName) firstStylePaletteName = key
             palettesIndex[key] = () => Promise.resolve(palette)
           })

src/stores/sync_config.js

@@ -195,9 +195,10 @@ export const _getRecentData = (cache, live, isTest) => {
 }
 
 export const _getAllFlags = (recent, stale) => {
+  const recentStorage = toRaw(recent?.flagStorage)
+  const staleStorage = toRaw(stale?.flagStorage)
+
   return Array.from(
-    recentStorage = toRaw(recent?.flagStorage)
-    staleStorage = toRaw(stale?.flagStorage)
     new Set([
       ...Object.keys(recentStorage || {}),
       ...Object.keys(staleStorage || {}),

test/unit/specs/components/rich_content.spec.js

@@ -363,10 +363,7 @@ describe('RichContent', () => {
     })
 
     expect(
-      wrapper
+      wrapper.html().replaceAll('\n', '').replaceAll('<!--.*?-->', ''),
-        .html()
-        .replaceAll('\n', '')
-        .replaceAll('<!--.*?-->', ''),
     ).to.eql(compwrap(expected))
   })
 
@@ -436,10 +433,7 @@ describe('RichContent', () => {
     })
 
     expect(
-      wrapper
+      wrapper.html().replaceAll('\n', '').replaceAll('<!--.*?-->', ''),
-        .html()
-        .replaceAll('\n', '')
-        .replaceAll('<!--.*?-->', ''),
     ).to.eql(compwrap(expected))
   })