Merge branch 'minimal-scopes-mode' into shigusegubu

* minimal-scopes-mode:
  fix lint
  fix formatting
  fix formatting
  Review
This commit is contained in:
Henry Jameson 2019-03-30 12:37:55 +02:00
commit 8baf0ce9ec
4 changed files with 12 additions and 4 deletions

10
BREAKING_CHANGES.md Normal file
View file

@ -0,0 +1,10 @@
# v1.0
## Removed features/radically changed behavior
### scopeOptionsMinimal
As of !633, `scopeOptions` is no longer available and instead is changed for `scopeOptionsMinimal` (default: `false`)
Reasoning is that scopeOptions option originally existed mostly as a backwards-compatibility with GNU Social which only had `public` scope available and using scope selector would''t work. Since at some point we dropped GNU Social support, this option was mostly a nuisance (being default `false`'), however some people think scopes are an annoyance to a certain degree and want as less of that feature as possible.
Solution - to only show minimal set among: *Direct*, *User default* and *Scope of post replying to*. This also makes it impossible to reply to a DM with a non-DM post from UI.
*This setting is admin-default, user-configurable. Admin can choose different default for their instance but user can override it.*

View file

@ -95,7 +95,7 @@ const setSettings = async ({ apiConfig, staticConfig, store }) => {
copyInstanceOption('redirectRootNoLogin')
copyInstanceOption('redirectRootLogin')
copyInstanceOption('showInstanceSpecificPanel')
copyInstanceOption('scopeOptionsEnabled')
copyInstanceOption('minimalScopesMode')
copyInstanceOption('formattingOptionsEnabled')
copyInstanceOption('hideMutedPosts')
copyInstanceOption('collapseMessageWithSubject')

View file

@ -50,7 +50,6 @@
<scope-selector
:showAll="showAllScopes"
:userEnabled="['direct']"
:userDefault="userDefaultScope"
:originalScope="copyMessageScope"
:initialScope="newStatus.visibility"

View file

@ -1,7 +1,6 @@
const ScopeSelector = {
props: [
'showAll',
'userEnabled',
'userDefault',
'originalScope',
'initialScope',
@ -43,7 +42,7 @@ const ScopeSelector = {
this.currentScope === scope ||
this.originalScope === scope ||
this.userDefault === scope ||
this.userEnabled.includes(scope)
scope === 'direct'
},
changeVis (scope) {
this.currentScope = scope