From 7aefda42110c703ad039a3858fa3e352a5d6db9c Mon Sep 17 00:00:00 2001 From: Alexander Tumin Date: Mon, 28 Jul 2025 11:39:50 +0300 Subject: [PATCH] Add quoting by url / in replies --- changelog.d/quote-by-url.add | 1 + src/components/chat/chat.vue | 1 + src/components/draft/draft.js | 7 +- .../edit_status_form/edit_status_form.vue | 1 + .../post_status_form/post_status_form.js | 99 ++++++++++++--- .../post_status_form/post_status_form.scss | 6 + .../post_status_form/post_status_form.vue | 31 ++++- src/components/quote/quote.js | 101 +++++++++++++++ src/components/quote/quote.vue | 82 ++++++++++++ src/components/quote/quote_form.js | 118 ++++++++++++++++++ src/components/quote/quote_form.vue | 55 ++++++++ src/components/status/status.js | 34 ++--- src/components/status/status.scss | 18 --- src/components/status/status.vue | 47 +------ .../status_action_buttons.scss | 2 +- src/i18n/en.json | 2 + src/services/api/api.service.js | 4 +- .../entity_normalizer.service.js | 2 +- 18 files changed, 501 insertions(+), 110 deletions(-) create mode 100644 changelog.d/quote-by-url.add create mode 100644 src/components/quote/quote.js create mode 100644 src/components/quote/quote.vue create mode 100644 src/components/quote/quote_form.js create mode 100644 src/components/quote/quote_form.vue diff --git a/changelog.d/quote-by-url.add b/changelog.d/quote-by-url.add new file mode 100644 index 000000000..ef401f93c --- /dev/null +++ b/changelog.d/quote-by-url.add @@ -0,0 +1 @@ +Add quoting by URL and in replies diff --git a/src/components/chat/chat.vue b/src/components/chat/chat.vue index dfd197e56..cedbdce69 100644 --- a/src/components/chat/chat.vue +++ b/src/components/chat/chat.vue @@ -73,6 +73,7 @@ :disable-notice="true" :disable-lock-warning="true" :disable-polls="true" + :disable-quotes="true" :disable-sensitivity-checkbox="true" :disable-submit="errorLoadingChat || !currentChat" :disable-preview="true" diff --git a/src/components/draft/draft.js b/src/components/draft/draft.js index 971a75b10..4f0d8cbee 100644 --- a/src/components/draft/draft.js +++ b/src/components/draft/draft.js @@ -43,7 +43,12 @@ const Draft = { } }, safeToSave() { - return this.draft.status || this.draft.files?.length || this.draft.hasPoll + return ( + this.draft.status || + this.draft.files?.length || + this.draft.hasPoll || + this.draft.hasQuote + ) }, postStatusFormProps() { return { diff --git a/src/components/edit_status_form/edit_status_form.vue b/src/components/edit_status_form/edit_status_form.vue index 0a7ec760a..1452be422 100644 --- a/src/components/edit_status_form/edit_status_form.vue +++ b/src/components/edit_status_form/edit_status_form.vue @@ -4,6 +4,7 @@ v-bind="params" :post-handler="doEditStatus" :disable-polls="true" + :disable-quotes="true" :disable-visibility-selector="true" /> diff --git a/src/components/post_status_form/post_status_form.js b/src/components/post_status_form/post_status_form.js index 507d12f6c..049183575 100644 --- a/src/components/post_status_form/post_status_form.js +++ b/src/components/post_status_form/post_status_form.js @@ -15,6 +15,7 @@ import EmojiInput from '../emoji_input/emoji_input.vue' import suggestor from '../emoji_input/suggestor.js' import MediaUpload from '../media_upload/media_upload.vue' import PollForm from '../poll/poll_form.vue' +import QuoteForm from '../quote/quote_form.vue' import ScopeSelector from '../scope_selector/scope_selector.vue' import Select from '../select/select.vue' import StatusContent from '../status_content/status_content.vue' @@ -35,6 +36,7 @@ import { faChevronRight, faCircleNotch, faPollH, + faQuoteRight, faSmileBeam, faTimes, faUpload, @@ -44,6 +46,7 @@ library.add( faSmileBeam, faPollH, faUpload, + faQuoteRight, faBan, faTimes, faCircleNotch, @@ -105,6 +108,7 @@ const PostStatusForm = { 'disableNotice', 'disableLockWarning', 'disablePolls', + 'disableQuotes', 'disableSensitivityCheckbox', 'disableSubmit', 'disablePreview', @@ -136,6 +140,7 @@ const PostStatusForm = { MediaUpload, EmojiInput, PollForm, + QuoteForm, ScopeSelector, Checkbox, Select, @@ -145,6 +150,9 @@ const PostStatusForm = { DraftCloser, Popover, }, + created() { + this.initQuote() + }, mounted() { this.updateIdempotencyKey() this.resize(this.$refs.textarea) @@ -203,6 +211,8 @@ const PostStatusForm = { files: [], poll: {}, hasPoll: false, + hasQuote: false, + quote: {}, mediaDescriptions: {}, visibility: scope, contentType, @@ -220,6 +230,8 @@ const PostStatusForm = { files: this.statusFiles || [], poll: this.statusPoll || {}, hasPoll: false, + hasQuote: false, + quote: {}, mediaDescriptions: this.statusMediaDescriptions || {}, visibility: this.statusScope || scope, contentType: statusContentType, @@ -345,12 +357,28 @@ const PostStatusForm = { isEdit() { return typeof this.statusId !== 'undefined' && this.statusId.trim() !== '' }, - quotable() { + quotingAvailable() { if (!useInstanceCapabilitiesStore().quotingAvailable) { return false } - if (!this.replyTo) { + return this.disableQuotes !== true + }, + isReply() { + return this.newStatus.type === 'reply' + }, + quotable() { + return this.quotingAvailable && this.replyTo + }, + quoteThreadToggled() { + return this.newStatus.hasQuote && this.newStatus.quote.thread + }, + defaultQuotable() { + if ( + !this.quotingAvailable || + !this.isReply || + !this.$store.getters.mergedConfig.quoteReply + ) { return false } @@ -372,12 +400,25 @@ const PostStatusForm = { return false }, + inReplyStatusId() { + return !this.newStatus.hasQuote || + !this.newStatus.quote.thread || + !this.newStatus.quote.id + ? this.replyTo + : undefined + }, + quoteId() { + return this.newStatus.hasQuote ? this.newStatus.quote.id : undefined + }, debouncedMaybeAutoSaveDraft() { return debounce(this.maybeAutoSaveDraft, 3000) }, pollFormVisible() { return this.newStatus.hasPoll }, + quoteFormVisible() { + return this.newStatus.hasQuote && !this.newStatus.quote.thread + }, shouldAutoSaveDraft() { return this.$store.getters.mergedConfig.autoSaveDraft }, @@ -395,7 +436,8 @@ const PostStatusForm = { (this.newStatus.status || this.newStatus.spoilerText || this.newStatus.files?.length || - this.newStatus.hasPoll) && + this.newStatus.hasPoll || + this.newStatus.hasQuote) && this.saveable ) }, @@ -406,7 +448,8 @@ const PostStatusForm = { this.newStatus.status || this.newStatus.spoilerText || this.newStatus.files?.length || - this.newStatus.hasPoll + this.newStatus.hasPoll || + this.newStatus.hasQuote ) ) }, @@ -456,11 +499,13 @@ const PostStatusForm = { contentType: newStatus.contentType, poll: {}, hasPoll: false, + hasQuote: false, + quote: {}, mediaDescriptions: {}, - quoting: false, } this.$refs.mediaUpload && this.$refs.mediaUpload.clearFile() this.clearPollForm() + this.clearQuoteForm() if (this.preserveFocus) { this.$nextTick(() => { this.$refs.textarea.focus() @@ -500,9 +545,7 @@ const PostStatusForm = { return } - const poll = this.newStatus.hasPoll - ? pollFormToMasto(this.newStatus.poll) - : {} + const poll = newStatus.hasPoll ? pollFormToMasto(newStatus.poll) : {} if (this.pollContentError) { this.error = this.pollContentError return @@ -518,10 +561,6 @@ const PostStatusForm = { return } - const replyOrQuoteAttr = newStatus.quoting - ? 'quoteId' - : 'inReplyToStatusId' - const postingOptions = { status: newStatus.status, spoilerText: newStatus.spoilerText || null, @@ -529,7 +568,8 @@ const PostStatusForm = { sensitive: newStatus.nsfw, media: newStatus.files, store: this.$store, - [replyOrQuoteAttr]: this.replyTo, + inReplyToStatusId: this.inReplyStatusId, + quoteId: this.quoteId, contentType: newStatus.contentType, poll, idempotencyKey: this.idempotencyKey, @@ -558,9 +598,7 @@ const PostStatusForm = { } const newStatus = this.newStatus this.previewLoading = true - const replyOrQuoteAttr = newStatus.quoting - ? 'quoteId' - : 'inReplyToStatusId' + statusPoster .postStatus({ status: newStatus.status, @@ -569,7 +607,8 @@ const PostStatusForm = { sensitive: newStatus.nsfw, media: [], store: this.$store, - [replyOrQuoteAttr]: this.replyTo, + inReplyToStatusId: this.inReplyStatusId, + quoteId: this.quoteId, contentType: newStatus.contentType, poll: {}, preview: true, @@ -813,6 +852,32 @@ const PostStatusForm = { this.$refs.pollForm.clear() } }, + initQuote() { + const quote = this.newStatus.quote + + if (Object.keys(quote).length > 0) { + return + } + + const quotable = this.defaultQuotable + + quote.id = quotable ? this.replyTo : '' + quote.url = '' + quote.thread = quotable + }, + setQuoteThread(v) { + this.newStatus.hasQuote = v + this.newStatus.quote.thread = v + this.newStatus.quote.id = v ? this.replyTo : '' + }, + clearQuoteForm() { + if (this.$refs.quoteForm) { + this.$refs.quoteForm.clear() + } + }, + toggleQuoteForm() { + this.newStatus.hasQuote = !this.newStatus.hasQuote + }, dismissScopeNotice() { this.$store.dispatch('setOption', { name: 'hideScopeNotice', diff --git a/src/components/post_status_form/post_status_form.scss b/src/components/post_status_form/post_status_form.scss index 641dc6dac..976a23f0a 100644 --- a/src/components/post_status_form/post_status_form.scss +++ b/src/components/post_status_form/post_status_form.scss @@ -137,11 +137,17 @@ .poll-icon { order: 3; + justify-content: center; + } + + .quote-icon { + order: 4; justify-content: right; } .media-upload-icon, .poll-icon, + .quote-icon, .emoji-icon { font-size: 1.85em; line-height: 1.1; diff --git a/src/components/post_status_form/post_status_form.vue b/src/components/post_status_form/post_status_form.vue index f661a980d..0eedea360 100644 --- a/src/components/post_status_form/post_status_form.vue +++ b/src/components/post_status_form/post_status_form.vue @@ -111,24 +111,26 @@ @@ -266,6 +268,13 @@ :visible="pollFormVisible" :params="newStatus.poll" /> + +
- - -

- - - -

+
{ if (data.ok) { return data } - throw new Error('Error fetching timeline', data) + throw new Error('Error fetching timeline', { cause: data }) }) .then((data) => data.json()) .then((data) => parseStatus(data)) @@ -706,7 +706,7 @@ const fetchStatusSource = ({ id, credentials }) => { if (data.ok) { return data } - throw new Error('Error fetching source', data) + throw new Error('Error fetching source', { cause: data }) }) .then((data) => data.json()) .then((data) => parseSource(data)) diff --git a/src/services/entity_normalizer/entity_normalizer.service.js b/src/services/entity_normalizer/entity_normalizer.service.js index 62d7fa855..909a014ce 100644 --- a/src/services/entity_normalizer/entity_normalizer.service.js +++ b/src/services/entity_normalizer/entity_normalizer.service.js @@ -383,7 +383,7 @@ export const parseStatus = (data) => { } output.summary_raw_html = escapeHtml(data.spoiler_text) - output.external_url = data.url + output.external_url = data.uri || data.url output.poll = data.poll if (output.poll) { output.poll.options = (output.poll.options || []).map((field) => ({