From 5d1b539da20950f05bf062df1a0904437c204e97 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Mon, 25 May 2020 16:48:23 +0300 Subject: [PATCH 1/8] lint --- src/components/settings_modal/settings_modal_content.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/settings_modal/settings_modal_content.vue b/src/components/settings_modal/settings_modal_content.vue index 847de1da7..865a2adff 100644 --- a/src/components/settings_modal/settings_modal_content.vue +++ b/src/components/settings_modal/settings_modal_content.vue @@ -10,7 +10,7 @@ v-if="currentSaveStateNotice.error" class="alert error" @click.prevent - > + > {{ $t('settings.saving_err') }} @@ -18,7 +18,7 @@ v-if="!currentSaveStateNotice.error" class="alert transparent" @click.prevent - > + > {{ $t('settings.saving_ok') }} From 534e1fef88862023cd85e29b265319da300b7995 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Mon, 25 May 2020 16:56:32 +0300 Subject: [PATCH 2/8] lint --- src/components/side_drawer/side_drawer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/side_drawer/side_drawer.js b/src/components/side_drawer/side_drawer.js index e0d118a14..d1f044f66 100644 --- a/src/components/side_drawer/side_drawer.js +++ b/src/components/side_drawer/side_drawer.js @@ -65,7 +65,7 @@ const SideDrawer = { }, openSettingsModal () { this.$store.dispatch('openSettingsModal') - }, + } } } From 500511b41534e051803db8731a6e6315447d5854 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Mon, 25 May 2020 17:05:30 +0300 Subject: [PATCH 3/8] fix sidebar not closing in mobile --- src/components/side_drawer/side_drawer.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/side_drawer/side_drawer.vue b/src/components/side_drawer/side_drawer.vue index aa39bc6fc..f253742d1 100644 --- a/src/components/side_drawer/side_drawer.vue +++ b/src/components/side_drawer/side_drawer.vue @@ -124,7 +124,7 @@
  • {{ $t("settings.settings") }} From 0eea5c6b80c1fcd9f99636599e484bac8845e075 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Mon, 25 May 2020 17:11:30 +0300 Subject: [PATCH 4/8] fix icon changing color --- src/components/tab_switcher/tab_switcher.scss | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/tab_switcher/tab_switcher.scss b/src/components/tab_switcher/tab_switcher.scss index 129a68b78..479fb6862 100644 --- a/src/components/tab_switcher/tab_switcher.scss +++ b/src/components/tab_switcher/tab_switcher.scss @@ -147,8 +147,10 @@ white-space: nowrap; padding: 6px 1em; - color: $fallback--text; - color: var(--tabText, $fallback--text); + &, &:active .tab-icon { + color: $fallback--text; + color: var(--tabText, $fallback--text); + } background-color: $fallback--fg; background-color: var(--tab, $fallback--fg); From c0fe39af7a817be47f3a80019127ddb74876222e Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Mon, 25 May 2020 17:15:02 +0300 Subject: [PATCH 5/8] increase gap between buttons in titlebars --- src/App.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/App.scss b/src/App.scss index 120eea533..f2972eda5 100644 --- a/src/App.scss +++ b/src/App.scss @@ -566,7 +566,7 @@ main-router { min-height: 0; box-sizing: border-box; margin: 0; - margin-left: .25em; + margin-left: .5em; min-width: 1px; align-self: stretch; } From ccdbba23485d90d437b0a3a19594faa25ef8833a Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Mon, 25 May 2020 17:18:57 +0300 Subject: [PATCH 6/8] Change flex for tab switcher lines to always have some small space reserved --- src/components/tab_switcher/tab_switcher.scss | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/components/tab_switcher/tab_switcher.scss b/src/components/tab_switcher/tab_switcher.scss index 479fb6862..fff6cc21a 100644 --- a/src/components/tab_switcher/tab_switcher.scss +++ b/src/components/tab_switcher/tab_switcher.scss @@ -65,14 +65,8 @@ overflow-y: auto; overflow-x: hidden; flex-direction: column; - &::after { - flex: 1 1 auto; - } - &::before { - flex: 0 0 auto; - height: 0.5em; - } &::after, &::before { + flex: 1 0 .5em; content: ''; border-right: 1px solid; border-right-color: $fallback--border; From 101f657d36275cf575ccbc45b556eb628bc8ad43 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Mon, 25 May 2020 17:21:05 +0300 Subject: [PATCH 7/8] improve big spinner visibility --- src/components/big_spinner/big_spinner.vue | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/components/big_spinner/big_spinner.vue b/src/components/big_spinner/big_spinner.vue index cda28de5a..64f16e4d8 100644 --- a/src/components/big_spinner/big_spinner.vue +++ b/src/components/big_spinner/big_spinner.vue @@ -9,5 +9,8 @@ font-size: 15em; line-height: 0; opacity: .6; + > i { + color: white; + } } From dc8f78e84dc2f125407cecd66cfaa814e131713a Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Mon, 25 May 2020 17:22:57 +0300 Subject: [PATCH 8/8] fix for a previous fix --- src/components/tab_switcher/tab_switcher.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/components/tab_switcher/tab_switcher.scss b/src/components/tab_switcher/tab_switcher.scss index fff6cc21a..d60e065bf 100644 --- a/src/components/tab_switcher/tab_switcher.scss +++ b/src/components/tab_switcher/tab_switcher.scss @@ -72,6 +72,9 @@ border-right-color: $fallback--border; border-right-color: var(--border, $fallback--border); } + &::before { + flex-grow: 0; + } .tab-wrapper { min-width: 10em; display: flex;