From 169d13680a72029cab71067abffbb4581cdb6b41 Mon Sep 17 00:00:00 2001 From: Tusooa Zhu Date: Sun, 10 Apr 2022 13:02:02 -0400 Subject: [PATCH 1/3] Fix image cropper not closing correctly --- src/components/image_cropper/image_cropper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/image_cropper/image_cropper.js b/src/components/image_cropper/image_cropper.js index e72ed0e89..05f6fd4cf 100644 --- a/src/components/image_cropper/image_cropper.js +++ b/src/components/image_cropper/image_cropper.js @@ -66,7 +66,7 @@ const ImageCropper = { } }, methods: { - unmounted () { + destroy () { if (this.cropper) { this.cropper.destroy() } From 3f9d9dd6bd9e15ea906d29ad04e35faa2a808367 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Sun, 10 Apr 2022 20:26:59 +0300 Subject: [PATCH 2/3] underlay improvements --- src/App.scss | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/App.scss b/src/App.scss index c8470c8a5..8c744752c 100644 --- a/src/App.scss +++ b/src/App.scss @@ -151,12 +151,11 @@ nav { grid-column-end: span 3; grid-row-start: 1; grid-row-end: 1; - margin: 0 calc(var(--columnGap) * -2); - padding: 0 calc(var(--columnGap) * 2); + margin: 0 calc(var(--columnGap) / -2); pointer-events: none; background-color: rgba(0, 0, 0, 0.15); background-color: var(--underlay, rgba(0, 0, 0, 0.15)); - z-index: -2000; + z-index: -1000; } .app-layout { @@ -174,7 +173,6 @@ nav { margin: 0 auto; align-content: flex-start; flex-wrap: wrap; - padding: 0 calc(var(--columnGap) / 2); justify-content: center; min-height: 100vh; From 62572c32049191328dfb8473ecf006cbfaa87413 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Sun, 10 Apr 2022 20:41:36 +0300 Subject: [PATCH 3/3] remove margins from underlay since it causes horizontal scroll on smaller screens --- src/App.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/App.scss b/src/App.scss index 8c744752c..01359f2c3 100644 --- a/src/App.scss +++ b/src/App.scss @@ -151,7 +151,6 @@ nav { grid-column-end: span 3; grid-row-start: 1; grid-row-end: 1; - margin: 0 calc(var(--columnGap) / -2); pointer-events: none; background-color: rgba(0, 0, 0, 0.15); background-color: var(--underlay, rgba(0, 0, 0, 0.15));