From 2097192469cf9fbb43eaac4041a88f6690e0e568 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 12 Feb 2025 20:53:06 +0200 Subject: [PATCH 1/6] lack of changelog --- changelog.d/roundup4.skip | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 changelog.d/roundup4.skip diff --git a/changelog.d/roundup4.skip b/changelog.d/roundup4.skip new file mode 100644 index 000000000..e69de29bb From 17d562b979fc4a57fd6e6ea6313c81ea5705ffe0 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 12 Feb 2025 21:07:16 +0200 Subject: [PATCH 2/6] fix draft dropdown --- .../post_status_form/post_status_form.js | 6 ++++ .../post_status_form/post_status_form.vue | 30 +++++++++++-------- 2 files changed, 23 insertions(+), 13 deletions(-) diff --git a/src/components/post_status_form/post_status_form.js b/src/components/post_status_form/post_status_form.js index 944c43153..f9eb1bdcd 100644 --- a/src/components/post_status_form/post_status_form.js +++ b/src/components/post_status_form/post_status_form.js @@ -363,6 +363,12 @@ const PostStatusForm = { } }, safeToSaveDraft () { + console.log('safe', ( + this.newStatus.status || + this.newStatus.spoilerText || + this.newStatus.files?.length || + this.newStatus.hasPoll + ) && this.saveable) return ( this.newStatus.status || this.newStatus.spoilerText || diff --git a/src/components/post_status_form/post_status_form.vue b/src/components/post_status_form/post_status_form.vue index e5eaa3af8..260a89cb7 100644 --- a/src/components/post_status_form/post_status_form.vue +++ b/src/components/post_status_form/post_status_form.vue @@ -334,22 +334,26 @@ class="dropdown-menu" role="menu" > - + + From c14f88e2906f02d1759e2e2b4c585be30390e9ea Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 12 Feb 2025 21:26:05 +0200 Subject: [PATCH 3/6] disable shadow inheritance --- src/App.scss | 5 +++++ src/panel.scss | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/App.scss b/src/App.scss index 78c20c0f9..db47c48b8 100644 --- a/src/App.scss +++ b/src/App.scss @@ -1096,3 +1096,8 @@ option { } } } + +@property --shadow { + syntax: "*"; + inherits: false; +} diff --git a/src/panel.scss b/src/panel.scss index 47d55aa4a..ecc39f43a 100644 --- a/src/panel.scss +++ b/src/panel.scss @@ -2,6 +2,7 @@ .panel { --__panel-background: var(--background); --__panel-backdrop-filter: var(--backdrop-filter); + --_shadow: var(--shadow); .tab-switcher .tabs { background: var(--__panel-background); @@ -29,7 +30,7 @@ left: 0; right: 0; z-index: 5; - box-shadow: var(--shadow); + box-shadow: var(--_shadow); pointer-events: none; } } @@ -154,11 +155,13 @@ linear-gradient(to bottom, var(--background), var(--background)), linear-gradient(to bottom, var(--__panel-background), var(--__panel-background)); + --_shadow: var(--shadow); + &::after { background-color: var(--background); z-index: -2; border-radius: var(--roundness) var(--roundness) 0 0; - box-shadow: var(--shadow); + box-shadow: var(--_shadow); } &:not(.-flexible-height) { From babe3697dbda0c7aefd7be2230dec0955600ed3e Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 12 Feb 2025 21:50:21 +0200 Subject: [PATCH 4/6] increase load time to avoid glitchiness --- src/App.scss | 2 -- src/services/theme_data/theme_data_3.service.js | 8 +++++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/App.scss b/src/App.scss index db47c48b8..6fa3a95b7 100644 --- a/src/App.scss +++ b/src/App.scss @@ -498,8 +498,6 @@ nav { box-sizing: content-box; color: inherit; - --shadow: none; - &.-link { /* stylelint-disable-next-line declaration-no-important */ color: var(--link) !important; diff --git a/src/services/theme_data/theme_data_3.service.js b/src/services/theme_data/theme_data_3.service.js index d4f88e883..33d860b8a 100644 --- a/src/services/theme_data/theme_data_3.service.js +++ b/src/services/theme_data/theme_data_3.service.js @@ -567,7 +567,13 @@ export const init = ({ if (!liteMode && combination.state.indexOf('hover') >= 0) { combination.lazy = true } - if (extraCompileComponents.has(component.name)) { + + if ( + parent?.component !== 'Root' && + !virtualComponents.has(component.name) && + !transparentComponents.has(component.name) && + extraCompileComponents.has(component.name) + ) { combination.lazy = true } From 3b2baa45d02ec4661780282f3f1dd8036ee16175 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 12 Feb 2025 22:00:37 +0200 Subject: [PATCH 5/6] fix checkboxes --- src/components/checkbox/checkbox.vue | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/components/checkbox/checkbox.vue b/src/components/checkbox/checkbox.vue index e447595f2..b6eab3ef7 100644 --- a/src/components/checkbox/checkbox.vue +++ b/src/components/checkbox/checkbox.vue @@ -85,6 +85,8 @@ export default { width: 1.2em; height: 1.2em; box-shadow: none; + + --_shadow: var(--shadow); } &-indicator::before { @@ -96,7 +98,7 @@ export default { width: 1.1em; height: 1.1em; border-radius: var(--roundness); - box-shadow: var(--shadow); + box-shadow: var(--_shadow); background-color: var(--background); vertical-align: top; text-align: center; From 89ba855e45fcdeff1ee716783f9dbce451c8615a Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 12 Feb 2025 22:06:13 +0200 Subject: [PATCH 6/6] make JPEG conversion a suboption --- .../settings_modal/tabs/general_tab.vue | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/components/settings_modal/tabs/general_tab.vue b/src/components/settings_modal/tabs/general_tab.vue index 9d23630a9..c8db96c5e 100644 --- a/src/components/settings_modal/tabs/general_tab.vue +++ b/src/components/settings_modal/tabs/general_tab.vue @@ -269,14 +269,17 @@ {{ $t('settings.image_compression') }} -
  • - - {{ $t('settings.always_use_jpeg') }} - -
  • +
      +
    • + + {{ $t('settings.always_use_jpeg') }} + +
    • +