From 5f2efc564ab597d8fb70c9374d6fc1a8ce6b13c5 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Tue, 16 Jun 2026 17:53:18 +0300 Subject: [PATCH 1/2] fix privileges.includes --- src/components/announcements_page/announcements_page.js | 2 +- src/components/user_card/user_card.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/announcements_page/announcements_page.js b/src/components/announcements_page/announcements_page.js index 3c73198c5..385a6f796 100644 --- a/src/components/announcements_page/announcements_page.js +++ b/src/components/announcements_page/announcements_page.js @@ -35,7 +35,7 @@ const AnnouncementsPage = { canPostAnnouncement() { return ( this.currentUser && - this.currentUser.privileges.includes( + this.currentUser.privileges.has( 'announcements_manage_announcements', ) ) diff --git a/src/components/user_card/user_card.js b/src/components/user_card/user_card.js index acb2c4ea1..3c9f55725 100644 --- a/src/components/user_card/user_card.js +++ b/src/components/user_card/user_card.js @@ -307,9 +307,9 @@ export default { const privileges = this.loggedIn.privileges return ( this.loggedIn.role === 'admin' || - privileges.includes('users_manage_activation_state') || - privileges.includes('users_delete') || - privileges.includes('users_manage_tags') + privileges.has('users_manage_activation_state') || + privileges.has('users_delete') || + privileges.has('users_manage_tags') ) }, hasNote() { From bb3c7b2178812ddfd5346d4b2a9a5aafe29d9284 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Tue, 16 Jun 2026 18:38:14 +0300 Subject: [PATCH 2/2] fix and unify list and bookmark editors --- .../bookmark_folder_card.js | 15 --- .../bookmark_folder_card.vue | 111 ------------------ .../bookmark_folders/bookmark_folders.js | 4 +- .../bookmark_folders/bookmark_folders.vue | 26 +++- src/components/folder_card/folder_card.js | 38 ++++++ src/components/folder_card/folder_card.vue | 84 +++++++++++++ src/components/lists/lists.js | 4 +- src/components/lists/lists.vue | 6 +- src/components/lists_card/lists_card.js | 10 -- src/components/lists_card/lists_card.vue | 38 ------ 10 files changed, 150 insertions(+), 186 deletions(-) delete mode 100644 src/components/bookmark_folder_card/bookmark_folder_card.js delete mode 100644 src/components/bookmark_folder_card/bookmark_folder_card.vue create mode 100644 src/components/folder_card/folder_card.js create mode 100644 src/components/folder_card/folder_card.vue delete mode 100644 src/components/lists_card/lists_card.js delete mode 100644 src/components/lists_card/lists_card.vue diff --git a/src/components/bookmark_folder_card/bookmark_folder_card.js b/src/components/bookmark_folder_card/bookmark_folder_card.js deleted file mode 100644 index 37b3f2e5e..000000000 --- a/src/components/bookmark_folder_card/bookmark_folder_card.js +++ /dev/null @@ -1,15 +0,0 @@ -import { library } from '@fortawesome/fontawesome-svg-core' -import { faEllipsisH } from '@fortawesome/free-solid-svg-icons' - -library.add(faEllipsisH) - -const BookmarkFolderCard = { - props: ['folder', 'allBookmarks'], - computed: { - firstLetter() { - return this.folder ? this.folder.name[0] : null - }, - }, -} - -export default BookmarkFolderCard diff --git a/src/components/bookmark_folder_card/bookmark_folder_card.vue b/src/components/bookmark_folder_card/bookmark_folder_card.vue deleted file mode 100644 index 9e8bef618..000000000 --- a/src/components/bookmark_folder_card/bookmark_folder_card.vue +++ /dev/null @@ -1,111 +0,0 @@ - - - - - diff --git a/src/components/bookmark_folders/bookmark_folders.js b/src/components/bookmark_folders/bookmark_folders.js index 9fd62dae0..cd12d4c3a 100644 --- a/src/components/bookmark_folders/bookmark_folders.js +++ b/src/components/bookmark_folders/bookmark_folders.js @@ -1,4 +1,4 @@ -import BookmarkFolderCard from 'src/components/bookmark_folder_card/bookmark_folder_card.vue' +import FolderCard from 'src/components/folder_card/folder_card.vue' import { useBookmarkFoldersStore } from 'src/stores/bookmark_folders.js' @@ -9,7 +9,7 @@ const BookmarkFolders = { } }, components: { - BookmarkFolderCard, + FolderCard, }, computed: { bookmarkFolders() { diff --git a/src/components/bookmark_folders/bookmark_folders.vue b/src/components/bookmark_folders/bookmark_folders.vue index fdd461064..56c9b62ce 100644 --- a/src/components/bookmark_folders/bookmark_folders.vue +++ b/src/components/bookmark_folders/bookmark_folders.vue @@ -12,14 +12,28 @@
- - + + + + {{ $t('nav.all_bookmarks') }} + +
+ diff --git a/src/components/folder_card/folder_card.js b/src/components/folder_card/folder_card.js new file mode 100644 index 000000000..7a68bc3ac --- /dev/null +++ b/src/components/folder_card/folder_card.js @@ -0,0 +1,38 @@ +import { library } from '@fortawesome/fontawesome-svg-core' +import { faEllipsisH } from '@fortawesome/free-solid-svg-icons' + +library.add(faEllipsisH) + +const FolderCard = { + props: { + name: { + type: String, + required: true, + }, + emoji: { + type: String, + required: false, + default: null, + }, + emojiUrl: { + type: String, + required: false, + default: null, + }, + link: { + type: Object, + required: true, + }, + linkEdit: { + type: Object, + required: true, + }, + }, + computed: { + firstLetter() { + return this.name[0] + }, + }, +} + +export default FolderCard diff --git a/src/components/folder_card/folder_card.vue b/src/components/folder_card/folder_card.vue new file mode 100644 index 000000000..043a326cc --- /dev/null +++ b/src/components/folder_card/folder_card.vue @@ -0,0 +1,84 @@ + + + + + diff --git a/src/components/lists/lists.js b/src/components/lists/lists.js index 9dcb7636c..7545d9126 100644 --- a/src/components/lists/lists.js +++ b/src/components/lists/lists.js @@ -1,4 +1,4 @@ -import ListsCard from 'src/components/lists_card/lists_card.vue' +import FolderCard from 'src/components/folder_card/folder_card.vue' import { useListsStore } from 'src/stores/lists.js' @@ -9,7 +9,7 @@ const Lists = { } }, components: { - ListsCard, + FolderCard, }, computed: { lists() { diff --git a/src/components/lists/lists.vue b/src/components/lists/lists.vue index 05df5b72f..f3987205e 100644 --- a/src/components/lists/lists.vue +++ b/src/components/lists/lists.vue @@ -14,10 +14,12 @@
-
diff --git a/src/components/lists_card/lists_card.js b/src/components/lists_card/lists_card.js deleted file mode 100644 index 81b811534..000000000 --- a/src/components/lists_card/lists_card.js +++ /dev/null @@ -1,10 +0,0 @@ -import { library } from '@fortawesome/fontawesome-svg-core' -import { faEllipsisH } from '@fortawesome/free-solid-svg-icons' - -library.add(faEllipsisH) - -const ListsCard = { - props: ['list'], -} - -export default ListsCard diff --git a/src/components/lists_card/lists_card.vue b/src/components/lists_card/lists_card.vue deleted file mode 100644 index a5dc6371e..000000000 --- a/src/components/lists_card/lists_card.vue +++ /dev/null @@ -1,38 +0,0 @@ - - - - -