Reverse changes related to mentionlink avatar, out of scope and too complicated

changelog.d/avatar_mentions.change

@@ -1 +0,0 @@
-If user avatars next to mentions are enabled it will show empty placeholder avatar next to label while user is being fetched, to avoid jumps

src/components/mention_link/mention_link.vue

@@ -8,20 +8,15 @@
       :href="url"
       class="original"
       target="_blank"
-    ><!-- eslint-enable vue/no-v-html -->
-      <UserAvatar
-        v-if="shouldShowAvatar"
-        class="mention-avatar"
-        :user-id="null"
-      />
-      <span v-html="content" />
-    </a>
+      v-html="content"
+    /><!-- eslint-enable vue/no-v-html -->
     <UserPopover
       v-else
       :user-id="user.id"
       :disabled="!shouldShowTooltip"
     >
       <span
+        v-if="user"
         class="new"
         :style="style"
         :class="classnames"

src/components/user_avatar/user_avatar.js

@@ -12,7 +12,7 @@ const UserAvatar = {
   props: {
     // UserID of a user to show avatar of
     userId: {
-      required: false, // You can pass null to just render a placeholder
+      required: true,
       type: String,
     },
     // Use less space and use alternative roundness

src/components/user_avatar/user_avatar.vue

@@ -70,7 +70,6 @@
 
     &.-placeholder {
       background-color: var(--background);
-      border: 1px solid var(--border)
     }
   }
 

test/unit/specs/components/rich_content.spec.js

@@ -354,13 +354,11 @@ describe('RichContent', () => {
         '<span class="MentionLink mention-link">',
         '<a href="lol" class="original" target="_blank">',
         '<span>',
-        '<span>',
         'https://</span>',
         '<span>',
         'lol.tld/</span>',
         '<span>',
         '</span>',
-        '</span>',
         '</a>',
         '</span>',
         '</span>',
@@ -420,25 +418,21 @@ describe('RichContent', () => {
       '<span class="MentionLink mention-link">',
       '<a href="lol" class="original" target="_blank">',
       '<span>',
-      '<span>',
       'https://</span>',
       '<span>',
       'lol.tld/</span>',
       '<span>',
       '</span>',
-      '</span>',
       '</a>',
       '</span>',
       '<span class="MentionLink mention-link">',
       '<a href="lol" class="original" target="_blank">',
       '<span>',
-      '<span>',
       'https://</span>',
       '<span>',
       'lol.tld/</span>',
       '<span>',
       '</span>',
-      '</span>',
       '</a>',
       '</span>',
       '</span>',