manual lint

src/components/contrast_ratio/contrast_ratio.vue

@@ -82,7 +82,9 @@ export default {
     contrast: {
       required: false,
       type: Object,
-      default: () => ({}),
+      default: () => ({
+        /* no-op */
+      }),
     },
     showRatio: {
       required: false,

src/components/dialog_modal/dialog_modal.js

@@ -5,7 +5,9 @@ const DialogModal = {
       type: Boolean,
     },
     onCancel: {
-      default: () => {},
+      default: () => {
+        /* no-op */
+      },
       type: Function,
     },
   },

src/components/nav_panel/nav_panel.js

@@ -45,7 +45,6 @@ library.add(
 )
 const NavPanel = {
   props: ['forceExpand', 'forceEditMode'],
-  created() {},
   components: {
     BookmarkFoldersMenuContent,
     ListsMenuContent,

src/components/rich_content/rich_content.jsx

@@ -1,7 +1,8 @@
-import { flattenDeep, unescape } from 'lodash'
+import { flattenDeep, unescape as ldUnescape } from 'lodash'
 import HashtagLink from 'src/components/hashtag_link/hashtag_link.vue'
 import { MENTIONS_LIMIT } from 'src/components/mentions_line/mentions_line.js'
 import MentionsLine from 'src/components/mentions_line/mentions_line.vue'
+import StillImage from 'src/components/still-image/still-image.vue'
 import StillImageEmojiPopover from 'src/components/still-image/still-image-emoji-popover.vue'
 import { convertHtmlToLines } from 'src/services/html_converter/html_line_converter.service.js'
 import { convertHtmlToTree } from 'src/services/html_converter/html_tree_converter.service.js'
@@ -268,7 +269,7 @@ export default {
         const emptyText = item.trim() === ''
         if (emptyText) return item
         if (!encounteredTextReverse) encounteredTextReverse = true
-        return unescape(item)
+        return ldUnescape(item)
       } else if (Array.isArray(item)) {
         // Handle tag nodes
         const [opener, children] = item

src/components/settings_modal/tabs/mutes_and_blocks_tab.js

@@ -17,14 +17,18 @@ const BlockList = withLoadMore({
   fetch: (props, $store) => $store.dispatch('fetchBlocks'),
   select: (props, $store) =>
     get($store.state.users.currentUser, 'blockIds', []),
-  destroy: () => {},
+  destroy: () => {
+    /* no-op */
+  },
   childPropName: 'items',
 })(SelectableList)
 
 const MuteList = withLoadMore({
   fetch: (props, $store) => $store.dispatch('fetchMutes'),
   select: (props, $store) => get($store.state.users.currentUser, 'muteIds', []),
-  destroy: () => {},
+  destroy: () => {
+    /* no-op */
+  },
   childPropName: 'items',
 })(SelectableList)
 

src/components/settings_modal/tabs/security_tab/confirm.js

@@ -1,6 +1,8 @@
 const Confirm = {
   props: ['disabled'],
-  data: () => ({}),
+  data: () => ({
+    /* no-op */
+  }),
   methods: {
     confirm() {
       this.$emit('confirm')

src/components/settings_modal/tabs/security_tab/mfa_backup_codes.js

@@ -8,7 +8,9 @@ export default {
       }),
     },
   },
-  data: () => ({}),
+  data: () => ({
+    /* no-op */
+  }),
   computed: {
     inProgress() {
       return this.backupCodes.inProgress

src/components/settings_modal/tabs/style_tab/style_tab.js

@@ -56,8 +56,7 @@ import Preview from '../old_theme_tab/theme_preview.vue'
 import VirtualDirectivesTab from './virtual_directives_tab.vue'
 
 // helper for debugging
-// eslint-disable-next-line no-unused-vars
-const toValue = (x) => JSON.parse(JSON.stringify(x === undefined ? 'null' : x))
+// const toValue = (x) => JSON.parse(JSON.stringify(x === undefined ? 'null' : x))
 
 // helper to make states comparable
 const normalizeStates = (states) =>

src/components/settings_modal/tabs/style_tab/virtual_directives_tab.js

@@ -7,8 +7,7 @@ import { serializeShadow } from 'src/services/theme_data/iss_serializer.js'
 import { computed, inject, ref, watch } from 'vue'
 
 // helper for debugging
-// eslint-disable-next-line no-unused-vars
-const toValue = (x) => JSON.parse(JSON.stringify(x === undefined ? 'null' : x))
+// const toValue = (x) => JSON.parse(JSON.stringify(x === undefined ? 'null' : x))
 
 export default {
   components: {

src/components/status/status.js

@@ -20,7 +20,7 @@ import {
   faThumbtack,
   faTimes,
 } from '@fortawesome/free-solid-svg-icons'
-import { unescape, uniqBy } from 'lodash'
+import { unescape as ldUnescape, uniqBy } from 'lodash'
 import MentionLink from 'src/components/mention_link/mention_link.vue'
 import MentionsLine from 'src/components/mentions_line/mentions_line.vue'
 import RichContent from 'src/components/rich_content/rich_content.jsx'
@@ -425,7 +425,7 @@ const Status = {
     },
     replySubject() {
       if (!this.status.summary) return ''
-      const decodedSummary = unescape(this.status.summary)
+      const decodedSummary = ldUnescape(this.status.summary)
       const behavior = this.mergedConfig.subjectLineBehavior
       const startsWithRe = decodedSummary.match(/^re[: ]/i)
       if ((behavior !== 'noop' && startsWithRe) || behavior === 'masto') {

src/components/status_action_buttons/action_button.js

@@ -123,7 +123,12 @@ export default {
         this.$store.dispatch('reactWithEmoji', { id: this.status.id, emoji })
       }
     },
-    doActionWrap(button, close = () => {}) {
+    doActionWrap(
+      button,
+      close = () => {
+        /* no-op */
+      },
+    ) {
       if (
         this.button.interactive ? !this.button.interactive(this.funcArg) : false
       )

src/components/status_action_buttons/status_action_buttons.js

@@ -20,7 +20,9 @@ const StatusActionButtons = {
       currentConfirmTitle: '',
       currentConfirmOkText: '',
       currentConfirmCancelText: '',
-      currentConfirmAction: () => {},
+      currentConfirmAction: () => {
+        /* no-op */
+      },
       randomSeed: genRandomSeed(),
     }
   },

src/components/status_action_buttons/status_action_buttons.vue

@@ -15,7 +15,7 @@
           :func-arg="funcArg"
           :get-class="getClass"
           :get-component="getComponent"
-          :close="() => {}"
+          :close="() => { /* no-op */ }"
           :do-action="doAction"
           @interacted="e => $emit('interacted')"
         />

src/components/thread_tree/thread_tree.js

@@ -54,10 +54,15 @@ const ThreadTree = {
       return selfSuspendable
     },
     reverseLookupTable() {
-      return this.conversation.reduce((table, status, index) => {
-        table[status.id] = index
-        return table
-      }, {})
+      return this.conversation.reduce(
+        (table, status, index) => {
+          table[status.id] = index
+          return table
+        },
+        {
+          /* no-op */
+        },
+      )
     },
     currentReplies() {
       return this.getReplies(this.status.id).map(({ id }) =>
@@ -75,9 +80,15 @@ const ThreadTree = {
     statusById(id) {
       return this.conversation[this.reverseLookupTable[id]]
     },
-    collapseThread() {},
-    showThread() {},
-    showAllSubthreads() {},
+    collapseThread() {
+      /* no-op */
+    },
+    showThread() {
+      /* no-op */
+    },
+    showAllSubthreads() {
+      /* no-op */
+    },
     toggleCurrentProp(name) {
       this.toggleStatusContentProperty(this.status.id, name)
     },

src/components/user_card/user_card.js

@@ -13,7 +13,7 @@ import {
 } from '@fortawesome/free-solid-svg-icons'
 import isEqual from 'lodash/isEqual'
 import merge from 'lodash/merge'
-import unescape from 'lodash/unescape'
+import ldUnescape from 'lodash/unescape'
 import Checkbox from 'src/components/checkbox/checkbox.vue'
 import ColorInput from 'src/components/color_input/color_input.vue'
 import DialogModal from 'src/components/dialog_modal/dialog_modal.vue'
@@ -128,7 +128,7 @@ export default {
       newName: user.name_unescaped,
       editingName: false,
 
-      newBio: unescape(user.description),
+      newBio: ldUnescape(user.description),
       editingBio: false,
 
       newAvatar: null,