From 11e6349e8d2952e687b28fb147ade6ac6d3058a4 Mon Sep 17 00:00:00 2001
From: Henry Jameson <me@hjkos.com>
Date: Thu, 7 Aug 2025 17:10:56 +0300
Subject: [PATCH] don't use newAvatar/Banner in non-editables

---
 src/components/user_card/user_card.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/components/user_card/user_card.js b/src/components/user_card/user_card.js
index 15e5b7c57..7daee4b76 100644
--- a/src/components/user_card/user_card.js
+++ b/src/components/user_card/user_card.js
@@ -282,12 +282,14 @@ export default {
     // Editable stuff
     avatarImgSrc () {
       const currentUrl = this.user.profile_image_url_original || this.defaultAvatar
-      const newUrl = this.newAvatar === '' ? this.defaultAvatar : this.newAvatar
+      if (!this.editable) return currentUrl
+      const newUrl = this.newAvatar === null ? this.defaultAvatar : this.newAvatar
       return (this.newAvatar === null) ? currentUrl : newUrl
     },
     bannerImgSrc () {
       const currentUrl = this.user.cover_photo || this.defaultBanner
-      const newUrl = this.newBanner === '' ? this.defaultBanner : this.newBanner
+      if (!this.editable) return currentUrl
+      const newUrl = this.newBanner === null ? this.defaultBanner : this.newBanner
       return (this.newBanner === null) ? currentUrl : newUrl
     },
     defaultAvatar () {